-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add RelayState Customizer to SAML Logout #12582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ghaege! I appreciate the contribution, and sorry that it took me a bit to get back to you. I've left some feedback inline. When you submit your update, please squash your commits into a single one.
In addition to that, please have that single commit include the bug that it being closed, like so:
Your Commit Title
Closes gh-12538
Thanks!
...ecurity/saml2/provider/service/web/authentication/logout/OpenSaml4LogoutRequestResolver.java
Show resolved
Hide resolved
...ecurity/saml2/provider/service/web/authentication/logout/OpenSaml4LogoutRequestResolver.java
Outdated
Show resolved
Hide resolved
...ecurity/saml2/provider/service/web/authentication/logout/OpenSaml4LogoutRequestResolver.java
Outdated
Show resolved
Hide resolved
...security/saml2/provider/service/web/authentication/logout/OpenSamlLogoutRequestResolver.java
Outdated
Show resolved
Hide resolved
...security/saml2/provider/service/web/authentication/logout/OpenSamlLogoutRequestResolver.java
Outdated
Show resolved
Hide resolved
...ty/saml2/provider/service/web/authentication/logout/OpenSaml4LogoutRequestResolverTests.java
Outdated
Show resolved
Hide resolved
...ecurity/saml2/provider/service/web/authentication/logout/OpenSaml4LogoutRequestResolver.java
Show resolved
Hide resolved
Thanks, @jzheaux for your feedback. Thanx for your understanding. |
Thanks, @ghaege. No problem, we'll make sure this gets in. To keep each commit atomic, I am going to need to split the unrelated cleanups into a separate commit. This will remove your authorship, and I want to make sure you get credit. So, what I propose is that I will instead add the relay state feature myself and add you as a co-author in the commit message. Does that sound okay to you? I'll go ahead and proceed this way if I don't hear from you in the next few days. If you want to resubmit the cleanups once you have time again, then you can always rebase your |
Perfect - do it like you proposed. |
Co-authored-by: ghaege <[email protected]> Issue spring-projectsgh-12538
Co-authored-by: ghaege <[email protected]> Closes spring-projectsgh-12538
Add RelayState Customizer to SAML Logout
Closes gh-12538