fixed Custom RelayState with OpenSamlLogoutRequestResolver #12565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ghaege Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@ghaege Thank you for signing the Contributor License Agreement! |
sjohnr
added
type: enhancement
jzheaux
requested changes
Jan 24, 2023
There was a problem hiding this comment.
Thanks, @ghaege! New features need to go into the latest minor release, so will you please rebase on main so that this goes out in 6.1?
Also, will you please update your commit messages in the following two ways:
- The title should be in the present tense and should probably say "Add" instead of "Fix" (since this is new behavior)
- The commit message should have "Closes Custom RelayState with OpenSamlLogoutRequestResolver #12538" at the bottom, like this:
Add RelayState Customizer to SAML Logout
Closes gh-12538
|
replaced by #12582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.