Skip to content

Fix JDK 10 & 11 builds #5860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Sep 18, 2018 · 3 comments
Closed

Fix JDK 10 & 11 builds #5860

rwinch opened this issue Sep 18, 2018 · 3 comments
Assignees
@jzheaux
Labels
in: build An issue in the build
Milestone
5.2.0.M1

Comments

@rwinch
Copy link
Member

rwinch commented Sep 18, 2018

Summary

Due to a Jenkins misconfiguration the build was not actually running on JDK 10 or 11. When Jenkins was fixed the build broke. We need to fix the build for JDK 10 and 11
@rwinch rwinch added the in: build An issue in the build label Sep 18, 2018
@rwinch rwinch added this to the 5.1.1 milestone Sep 18, 2018
rwinch added a commit that referenced this issue Sep 18, 2018
@rwinch
Remove JDK 10/11 from Jenkinsfile
12c17e8 
This is necessary until we can figure out how to fix the build.

Issue: gh-5860
@rwinch rwinch modified the milestones: 5.1.1, 5.1.2 Oct 12, 2018
@jzheaux jzheaux mentioned this issue Oct 16, 2018
Closed
jzheaux added a commit to jzheaux/spring-security that referenced this issue Oct 16, 2018
@jzheaux
JDK 10 Compatibility
8efdaaf 
Upgrading dependencies and reconfiguring PowerMock

Issue: spring-projectsgh-5860
jzheaux added a commit to jzheaux/spring-security that referenced this issue Oct 16, 2018
@jzheaux
Add JDK 10 to Jenkins
7ebe2bf 
Fixes: spring-projectsgh-5860
rwinch pushed a commit that referenced this issue Oct 17, 2018
@jzheaux @rwinch
JDK 10 Compatibility
bd9e387 
Upgrading dependencies and reconfiguring PowerMock

Issue: gh-5860
@rwinch rwinch closed this as completed in adb9f4e Oct 17, 2018
@rwinch rwinch modified the milestones: 5.1.2, 5.2.0.M1 Oct 17, 2018
rwinch pushed a commit that referenced this issue Oct 17, 2018
@jzheaux @rwinch
JDK 10 Compatibility
1eb56f4 
Upgrading dependencies and reconfiguring PowerMock

Issue: gh-5860
rwinch pushed a commit that referenced this issue Oct 17, 2018
@jzheaux @rwinch
Add JDK 10 to Jenkins
0a4ac4d 
Fixes: gh-5860
@rwinch rwinch reopened this Oct 17, 2018
@rwinch
Copy link
Member Author

rwinch commented Oct 17, 2018

We haven't fixed JDK 11 yet, so reopening

@jzheaux jzheaux mentioned this issue Oct 19, 2018
Closed
jzheaux added a commit that referenced this issue Oct 25, 2018
@jzheaux
JDK 11 Compatibility
42b111f 
Upgraded dependencies and removed a test in the Java Config LDAP
sample which is arguably an integration test since it starts up an
LDAP container. This test also isn't JDK 11 compatible and the
remaining integration tests in the sample cover the same material.

Issue: gh-5860
jzheaux added a commit that referenced this issue Oct 26, 2018
@jzheaux
JDK 11 Compatibility
ccd2664 
Upgraded dependencies and removed a test in the Java Config LDAP
sample which is arguably an integration test since it starts up an
LDAP container. This test also isn't JDK 11 compatible and the
remaining integration tests in the sample cover the same material.

Issue: gh-5860
jzheaux added a commit that referenced this issue Oct 26, 2018
@jzheaux
Add JDK 11 to Jenkins
d99ecc2 
Fixes: gh-5860
@rwinch rwinch mentioned this issue May 13, 2019
Closed
@bberto
Copy link
Contributor

bberto commented Apr 16, 2020

Building with OpenJDK 11 from master I get this:

> Task :spring-security-itest-ldap-embedded-apacheds-default:integrationTest

org.springframework.security.LdapServerBeanDefinitionParserTests > apacheDirectoryServerIsStartedByDefault FAILED
    org.springframework.beans.factory.BeanCreationException at LdapServerBeanDefinitionParserTests.java:38
        Caused by: java.lang.NoClassDefFoundError at LdapServerBeanDefinitionParserTests.java:38
            Caused by: java.lang.ClassNotFoundException at LdapServerBeanDefinitionParserTests.java:38

so I think this issue should be reopened. TravisCI builds with openjdk8

@rwinch
Copy link
Member Author

rwinch commented Apr 16, 2020

@bberto If you have found an issue in master, please create a new issue with details on how to reproduce. Please note that we run our build in Jenkins which builds against JDK 8, 9, 10, 11, and 12 so there is likely some other difference causing the problem. That means the more details you can provide the more likely we will be able to figure out the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: build An issue in the build
Projects
None yet
Milestone
5.2.0.M1
Development

No branches or pull requests
3 participants
@rwinch @bberto @jzheaux