Skip to content

Fix and polish grading submissions table logic #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

josh1248
Copy link
Contributor

Description

Type of change

#2383 Bugfix - This change allows entries per page functionality to function by dynamically resizing the max entries per page in tanstack to match the set value by the user.

Pre-emptive bugfix - This change refines page logic for the search bar by assessment. It now resets the page when the search value is updated to prevent an out of bounds page index.

Pre-emptive bugfix - This change refines page logic for column filters. The page number currently resets for adding column filters only. This change additionally resets the page number for removing column filter for logic handling consistency.

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@josh1248 josh1248 requested a review from RichDom2185 February 27, 2024 08:58
@josh1248 josh1248 self-assigned this Feb 27, 2024
@coveralls
Copy link

coveralls commented Feb 27, 2024

Pull Request Test Coverage Report for Build 8062504049

Details

  • -9 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 37.949%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/grading/subcomponents/GradingSubmissionsTable.tsx 0 9 0.0%
Totals Coverage Status
Change from base Build 8053250310: -0.007%
Covered Lines: 5810
Relevant Lines: 14373

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for fixing them!

@RichDom2185 RichDom2185 merged commit 9f7b414 into source-academy:master Feb 27, 2024
@josh1248 josh1248 deleted the fix/paginationlogic branch February 27, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grading UI/UX: Grading Overview Showing X Entries Per Page Incorrect
3 participants