-
Notifications
You must be signed in to change notification settings - Fork 172
Shorten editor tab file paths #2383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4508193665Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
zhaojj2209
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We need to pass in an empty string instead of '/' because otherwise, the first slash of file paths would be removed and the result would not be file paths.
RichDom2185
pushed a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Jul 15, 2023
* Shorten editor tab file paths * Remove empty file path segments * Add test cases for getting the shortened unique file paths * Exclude the workspace base path from being displayed in editor tab * Add comments & better name variables in getShortestUniqueFilePaths * Fix value of default base file path We need to pass in an empty string instead of '/' because otherwise, the first slash of file paths would be removed and the result would not be file paths.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When displaying file paths in the editor tab, show the shortest possible file path that uniquely identifies each tab among all open tabs. This is similar to how most code editors do it.
Part of #2176.
Type of change
How to test
The multiple files mode is not yet ready for production and is disabled programmatically. Enable multiple files mode for testing by changing the condition to
false
:frontend/src/pages/playground/Playground.tsx
Lines 603 to 615 in 9bc1140