Skip to content
This repository was archived by the owner on Dec 6, 2023. It is now read-only.

explicitly require Python 3.6 and drop six dependency #170

Merged
merged 1 commit into from
May 10, 2021
Merged

explicitly require Python 3.6 and drop six dependency #170

merged 1 commit into from
May 10, 2021

Conversation

StrikerRUS
Copy link
Contributor

Linking
#142 (comment)

This PR should be treated as a hotfix, and ideally lightning should drop the support of Python 2 with six dependency.

and
#161 (comment)

Libraries have agonized over this for a long time before py2 was sunset. Now that it has, I think it's ok and better to officially drop support.

Comment on lines +69 to +70
lightning requires Python >= 3.6, setuptools, Numpy >= 1.12, SciPy >= 0.19 and
scikit-learn >= 0.19. Building from source also requires Cython and a working C/C++ compiler. To run the tests you will also need pytest.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the first versions for which Python 3.6 wheels were uploaded to PyPI.

@StrikerRUS
Copy link
Contributor Author

Looks like http://contrib.scikit-learn.org/lightning/ is not in sync with the current master, e.g.

image

image

Are docs builds there triggered manually or is there any sphinx compiling error? I'm not able to see the logs (or don't know where to search for them).

@StrikerRUS StrikerRUS marked this pull request as ready for review May 8, 2021 15:46
@StrikerRUS
Copy link
Contributor Author

@mblondel @vene
Thanks for your time and consideration!

@mblondel
Copy link
Member

mblondel commented May 8, 2021

The documentation needs to be manually updated in the gh-pages branch.

@mblondel mblondel merged commit a327bbb into scikit-learn-contrib:master May 10, 2021
@mblondel
Copy link
Member

Merged! I don't know how to automatically upload the website.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants