-
Notifications
You must be signed in to change notification settings - Fork 215
[HOTFIX] fix compatibility with new scikit-learn version #142
[HOTFIX] fix compatibility with new scikit-learn version #142
Conversation
I don't think that |
Hello @mblondel @MechCoder @zermelozf @fabianp ! Can you please clarify the status of this great project? Is it abandoned? This project is no longer compatible with scikit-learn and requires some hotfixes (presented in this PR). |
Merging. Thanks a lot and sorry for the delay! The project is indeed no longer actively maintained but hot fixes like this to follow the latest scikit-learn are very welcome. |
@mblondel Thank you very much for your response and for merging this PR! I'm happy to help. BTW, it will be cool to release a new version of the project at PyPI. The latest release was in 2017 and I believe there are some critical hotfixes (#142 and #134) in the |
@mblondel Hello! Is it possible to release a fresh version of this project on PyPI? |
@mblondel Could this be released to PyPI? |
@fabianp Do you think you could take care of this? Personally, I don't have the bandwidth to do it. If nobody can do it, I suggest we remove lightning from pip and switch to a |
Thanks so much! 🎉 |
This PR will allow using
lightning
with the latest version (0.23.0
) ofscikit-learn
.Right now if you try to upgrade
scikit-learn
,lightning
fails with the error about that it cannot import neitherjoblib
norsix
because they are no longer exist insklearn.externals
:six
was dropped along with Python 2 support.https://scikit-learn.org/stable/whats_new/v0.21.html#sklearn-externals
joblib
is now a dependency:https://scikit-learn.org/stable/whats_new/v0.21.html#miscellaneous
This PR should be treated as a hotfix, and ideally
lightning
should drop the support of Python 2 withsix
dependency.