Fix: Add Doctype to be in standard mode #17087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florian3k
reviewed
Mar 13, 2023
Dedelweiss
force-pushed
the
quirk_mode
branch
5 times, most recently
from
bed1eff to
0e4b999
Compare
Add Doctype Correction Correct
Dedelweiss
changed the title
Dedelweiss
added a commit
to Dedelweiss/dotty
that referenced
this pull request
Apr 17, 2023
In this PR, I added the `<!DOCTYPE html>` in the HtmlRenderer file. I combined in the def page content the tag html with all the content of the page (head, body,...) and the Doctype. ## Result : <img width="400" alt="Screenshot 2023-03-13 at 16 03 43" src="https://user-images.githubusercontent.com/44496264/224742326-280b1f86-e578-4f25-8d13-9ca39f6c0aec.png"> (On chrome) <img width="400" alt="Screenshot 2023-03-13 at 16 04 36" src="https://user-images.githubusercontent.com/44496264/224742405-c5dbc809-c085-4cde-aa4d-4faffc088682.png"> Fixes scala#16803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I added the
<!DOCTYPE html>in the HtmlRenderer file.I combined in the def page content the tag html with all the content of the page (head, body,...) and the Doctype.
Result :
(On chrome)
Fixes #16803