Skip to content

DOCTYPE missing from scaladoc #16803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JD557 opened this issue Feb 1, 2023 · 0 comments · Fixed by #17087
Closed

DOCTYPE missing from scaladoc #16803

JD557 opened this issue Feb 1, 2023 · 0 comments · Fixed by #17087
Assignees
@Florian3k
Labels
area:doctool itype:bug
Milestone
3.3.1

Comments

@JD557
Copy link
Contributor

JD557 commented Feb 1, 2023

On all Scala 3 versions (currently up to 3.2.2), the scaladoc pages are missing the <!DOCTYPE html>

This forces browsers to render it in quirks mode

This was working fine on Scala 2.
@JD557 JD557 added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels Feb 1, 2023
@Kordyjan Kordyjan added area:doctool and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Feb 2, 2023
@Dedelweiss Dedelweiss mentioned this issue Mar 11, 2023
Merged
ckipp01 pushed a commit that referenced this issue Mar 27, 2023
@Dedelweiss
Fix: Add Doctype to be in standard mode (#17087)
0625d1c 
In this PR, I added the `<!DOCTYPE html>` in the HtmlRenderer file. 
I combined in the def page content the tag html with all the content of
the page (head, body,...) and the Doctype.

## Result :
<img width="400" alt="Screenshot 2023-03-13 at 16 03 43"
src="https://user-images.githubusercontent.com/44496264/224742326-280b1f86-e578-4f25-8d13-9ca39f6c0aec.png">

(On chrome)
<img width="400" alt="Screenshot 2023-03-13 at 16 04 36"
src="https://user-images.githubusercontent.com/44496264/224742405-c5dbc809-c085-4cde-aa4d-4faffc088682.png">

Fixes #16803
Dedelweiss added a commit to Dedelweiss/dotty that referenced this issue Apr 17, 2023
@Dedelweiss
Fix: Add Doctype to be in standard mode (scala#17087)
dfcbcb1 
In this PR, I added the `<!DOCTYPE html>` in the HtmlRenderer file. 
I combined in the def page content the tag html with all the content of
the page (head, body,...) and the Doctype.

## Result :
<img width="400" alt="Screenshot 2023-03-13 at 16 03 43"
src="https://user-images.githubusercontent.com/44496264/224742326-280b1f86-e578-4f25-8d13-9ca39f6c0aec.png">

(On chrome)
<img width="400" alt="Screenshot 2023-03-13 at 16 04 36"
src="https://user-images.githubusercontent.com/44496264/224742405-c5dbc809-c085-4cde-aa4d-4faffc088682.png">

Fixes scala#16803
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Florian3k Florian3k

Labels
area:doctool itype:bug
Projects
None yet
Milestone
3.3.1
Development

Successfully merging a pull request may close this issue.

Fix: Add Doctype to be in standard mode Dedelweiss/dotty
3 participants
@JD557 @Kordyjan @Florian3k