Return Range.Exclusive on RichInt.until instead of abstract Range #8680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#11875
Shuffling an exclusive range of
Int
s created usinguntil
would fail in the block below as a result of the return type being an abstract type:Range
, causing theRandom.shuffle
to look for an implicit of type:scala.collection.BuildFrom[Range, Int, _]
.In addition, this change would also align the types which extend
RangedProxy[T]
, namely:RichInt
andIntegralProxy[T]
in terms of their return types for.until
. WhileIntegralProxy[T].until
already returned aNumericRange.Exclusive[T]
,RichInt.until
returned an abstractRange
.P.S.: This is my first PR here. Any feedback/suggestions are welcome and would be greatly appreciated. Thanks