Skip to content

Scabot is ignoring a Dotty PR #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SethTisue opened this issue Sep 22, 2015 · 1 comment
Closed

Scabot is ignoring a Dotty PR #48

SethTisue opened this issue Sep 22, 2015 · 1 comment
Assignees
@SethTisue

Comments

@SethTisue
Copy link
Member

namely scala/scala3#802
@SethTisue SethTisue self-assigned this Sep 22, 2015
@SethTisue
Copy link
Member Author

the problem is that GithubApi.pullRequestCommits is only returning the first 30 commits:

scala> val c = new scabot.cli.CLI("dotty")
c: scabot.cli.CLI = scabot.cli.CLI@316e30f5

scala> c.await(c.api.pullRequestCommits(802)).size
res2: Int = 30

this PR has more than 30 commits, but Scabot thinks the 30th one is the last one.

SethTisue added a commit that referenced this issue Sep 22, 2015
@SethTisue
Merge pull request #49 from SethTisue/issue/48
2903046 
fix #48 (handle more than 30 commits in a PR)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SethTisue