Merge pull request #49 from SethTisue/issue/48

fix #48 (handle more than 30 commits in a PR)

Author: SethTisue

.travis.yml

@@ -2,7 +2,7 @@ language: scala
 script:
   - sbt ++$TRAVIS_SCALA_VERSION compile
 scala:
-  - 2.11.6
+  - 2.11.7
 # we actually build and run on openjdk8 in production, see scala-jenkins-infra.
 # but (as of June 2015) Travis only supports Oracle Java 8, not OpenJDK 8
 jdk:

build.sbt

@@ -2,15 +2,15 @@ name := "scabot"
 
 organization in ThisBuild := "com.typesafe"
 version      in ThisBuild := "0.1.0"
-scalaVersion in ThisBuild := "2.11.6"
+scalaVersion in ThisBuild := "2.11.7"
 
 scalacOptions in ThisBuild ++=
   Seq("-feature", "-deprecation", "-Xfatal-warnings")
 
 lazy val deps: Seq[sbt.Def.Setting[_]] =  Seq(
   libraryDependencies ++= Seq(
-    "com.typesafe.akka" %% "akka-actor"     % "2.3.9",
-    "com.typesafe.akka" %% "akka-kernel"    % "2.3.9",
+    "com.typesafe.akka" %% "akka-actor"     % "2.3.14",
+    "com.typesafe.akka" %% "akka-kernel"    % "2.3.14",
     "io.spray"          %% "spray-client"   % "1.3.2",
     "io.spray"          %% "spray-json"     % "1.3.1"
   ))

cli.conf

@@ -14,3 +14,20 @@ scala: {
     token: ""
   }
 }
+
+dotty: {
+  jenkins: {
+    jobSuffix: ""
+    host:  ""
+    user:  ""
+    token: ""
+  }
+  github: {
+    user:  "lampepfl"
+    repo:  "dotty"
+    branches: ["master"]
+    lastCommitOnly: true
+    host:  "api.github.com"
+    token: ""
+  }
+}

github/src/main/scala/scabot/github/GithubApi.scala

@@ -6,6 +6,17 @@
 // of a user name and a repository name.  The user name might be an
 // individual's, but is more likely an organization name.
 
+// A note on pagination: many API calls only return the first n
+// results, where n is often 30 but may be 100 or a different
+// number depending on the particular call.  This can lead to
+// random-seeming failage when we happen to exceed the limit.
+// For now, we add `per_page` if the limit is found to be a
+// problem in practice.  per_page cannot be increased past
+// 100; if we ever find that's not enough in practice, we'd
+// have to add additional code to split the request into
+// multiple pages. relevant doc:
+// * https://developer.github.com/guides/traversing-with-pagination/
+
 package scabot
 package github
 
@@ -163,7 +174,8 @@ trait GithubApiActions extends GithubJsonProtocol with core.HttpClient {
     def pullRequests                               = p[List[PullRequest]] (Get(api("pulls")))
     def closedPullRequests                         = p[List[PullRequest]] (Get(api("pulls") withQuery Map("state" -> "closed")))
     def pullRequest(nb: Int)                       = p[PullRequest]       (Get(api("pulls" / nb)))
-    def pullRequestCommits(nb: Int)                = p[List[Commit]]      (Get(api("pulls" / nb / "commits")))
+    def pullRequestCommits(nb: Int)                = p[List[Commit]]      (Get(api("pulls" / nb / "commits")
+                                                                                 withQuery Map("per_page" -> "100")))
     def deletePRComment(id: String)                = px                (Delete(api("pulls" / "comments" / id)))
 
     def issueComments(nb: Int)                     = p[List[IssueComment]](Get(api("issues" / nb / "comments")))

project/build.properties

@@ -1 +1 @@
-sbt.version = 0.13.8
+sbt.version = 0.13.9