Add time/ram benchmark crate by White-Oak #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
requested changes
Sep 26, 2017
There was a problem hiding this comment.
Thanks! This looks good, and feel free to ignore the Travis failure -- that's something that's been broken for a while (I should fix it). However, I noticed there's a few seemingly unrelated files -- some time-passes logs and a long_names.txt. I assume those aren't needed for the benchmark to run; could you remove them?
| @@ -0,0 +1,3 @@ | |||
| *.lock | |||
|
|
|||
There was a problem hiding this comment.
Looks like a spurious empty line here.
Mark-Simulacrum
approved these changes
Sep 26, 2017
|
Thanks! I'll merge as soon as you've squashed the two commits together. You might be interested in repeating this PR with #142. |
|
think I might have messed that squash up, I'm not terribly great with git it seems... edit: got there in the end |
Various cleanups
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it's all good, should close #148, but let me know if something isn't quite right