Skip to content

Bench optimized builds #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oyvindln opened this issue Aug 13, 2017 · 8 comments
Closed

Bench optimized builds #140

oyvindln opened this issue Aug 13, 2017 · 8 comments
Labels
design ready E-mentor This issue has mentoring instructions P-med Medium priority

Comments

@oyvindln
Copy link
Contributor

Looking at this repo and rustc-benchmarks, it doesn't look like there is any benchmarks done of optimized/release mode builds. (Or am I missing something?)

Wouldn't it make sense to check the performance of this as well?

@Mark-Simulacrum
Copy link
Member

We don't check compile times on release benchmarks currently. I don't think our current infrastructure can really support that (it'd take too long for most of these) but I'd be willing to look at options if we wanted it. cc @alexcrichton @nikomatsakis @aturon -- do we want this?

@alexcrichton
Copy link
Member

Seems desirable to me! We probably don't want to double all our collected benchmarks but we can select a few "LLVM stressors" and see what optimized build times look like.

@Mark-Simulacrum
Copy link
Member

@aturon Could you suggest someone (@nikomatsakis?) to find or select a few LLVM stressing benchmarks to enable release mode on? We can then add those.

@alexcrichton
Copy link
Member

I'd imagine we already have some great candidates -- regex, syntex_syntax, tokio-webpush, etc.

@Mark-Simulacrum
Copy link
Member

Let's promote the (newer) incremental regex. We can also promote tokio webpush, syntex_syntax will take too long I think. Marking for impl period, happy to mentor.

@Mark-Simulacrum Mark-Simulacrum added E-mentor This issue has mentoring instructions P-med Medium priority design ready labels Sep 9, 2017
@Mark-Simulacrum Mark-Simulacrum added this to the Impl Period milestone Sep 9, 2017
@michaelwoerister
Copy link
Member

+1 for also testing optimized builds of regex.

@oyvindln
Copy link
Contributor Author

If there is some mentoring available, I can have a go at this one.

@Mark-Simulacrum
Copy link
Member

Sure! You can look at how #151 was implemented, and you'd probably add --release to the cargo rustc invocations. Let's call it regex-opt-version and copy both regex-0.1.80 and regex.0.1.30 over. Let me know if you'd like further assistance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design ready E-mentor This issue has mentoring instructions P-med Medium priority
Projects
None yet
Development

No branches or pull requests

4 participants