-
Notifications
You must be signed in to change notification settings - Fork 154
Bench optimized builds #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We don't check compile times on release benchmarks currently. I don't think our current infrastructure can really support that (it'd take too long for most of these) but I'd be willing to look at options if we wanted it. cc @alexcrichton @nikomatsakis @aturon -- do we want this? |
Seems desirable to me! We probably don't want to double all our collected benchmarks but we can select a few "LLVM stressors" and see what optimized build times look like. |
@aturon Could you suggest someone (@nikomatsakis?) to find or select a few LLVM stressing benchmarks to enable release mode on? We can then add those. |
I'd imagine we already have some great candidates -- regex, syntex_syntax, tokio-webpush, etc. |
Let's promote the (newer) incremental regex. We can also promote tokio webpush, syntex_syntax will take too long I think. Marking for impl period, happy to mentor. |
+1 for also testing optimized builds of regex. |
If there is some mentoring available, I can have a go at this one. |
Sure! You can look at how #151 was implemented, and you'd probably add |
Looking at this repo and rustc-benchmarks, it doesn't look like there is any benchmarks done of optimized/release mode builds. (Or am I missing something?)
Wouldn't it make sense to check the performance of this as well?
The text was updated successfully, but these errors were encountered: