Improve docs & doc examples for HashSet. #43585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
force-pushed
the
frewsxcv-hashset-docs
branch
from
2b069c3 to
00d72a1
Compare
| @@ -146,7 +146,8 @@ impl<T: Hash + Eq> HashSet<T, RandomState> { | |||
| /// | |||
| /// ``` | |||
| /// use std::collections::HashSet; | |||
| /// let mut set: HashSet<i32> = HashSet::with_capacity(10); | |||
| /// let set: HashSet<i32> = HashSet::with_capacity(10); | |||
| /// assert!(set.capacity() >= 10); | |||
There was a problem hiding this comment.
Shouldn't it be more accurate to check if the capacity is equal to 10 instead of >= ?
There was a problem hiding this comment.
In general, the allocator may give you more than you asked for.
|
Just a small nit. Also, is it normal that you have this much commits? |
steveklabnik
approved these changes
Aug 1, 2017
|
Travis says the build was cancelled before it ever started (??) but otherwise the change looks good. |
frewsxcv
force-pushed
the
frewsxcv-hashset-docs
branch
from
00d72a1 to
d9df296
Compare
|
rebased, tests pass @bors r=steveklabnik,quietmisdreavus rollup |
|
📌 Commit d9df296 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 2, 2017
…teveklabnik,quietmisdreavus Improve docs & doc examples for HashSet. None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.