Skip to content

Thread through the original error when opening archives #43389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

alexcrichton
Copy link
Member

This updates the management of opening archives to thread through the original
piece of error information from LLVM over to the end consumer, trans.

This updates the management of opening archives to thread through the original
piece of error information from LLVM over to the end consumer, trans.
@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2017
@alexcrichton
Copy link
Member Author

r? @michaelwoerister

Mind taking over the review from @pnkfelix who I think's on PTO?

@michaelwoerister
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 31, 2017

📌 Commit 81eea9e has been approved by michaelwoerister

@bors
Copy link
Collaborator

bors commented Jul 31, 2017

⌛ Testing commit 81eea9e with merge 72833e4...

bors added a commit that referenced this pull request Jul 31, 2017
Thread through the original error when opening archives

This updates the management of opening archives to thread through the original
piece of error information from LLVM over to the end consumer, trans.
@carols10cents
Copy link
Member

friendly ping for review @michaelwoerister ! pinging you on IRC too!

@carols10cents
Copy link
Member

oops sorry github hadn't reloaded this tab ignore me

@carols10cents carols10cents added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 2, 2017
…lwoerister

Thread through the original error when opening archives

This updates the management of opening archives to thread through the original
piece of error information from LLVM over to the end consumer, trans.
bors added a commit that referenced this pull request Aug 2, 2017
Rollup of 6 pull requests

- Successful merges: #43389, #43423, #43581, #43585, #43597, #43598
- Failed merges:
@bors bors merged commit 81eea9e into rust-lang:master Aug 2, 2017
@alexcrichton alexcrichton deleted the thread-error branch August 22, 2017 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants