Add doc examples & description in `std::os::unix::ffi`. #39065

frewsxcv · 2017-01-14T17:42:14Z

No description provided.

frewsxcv · 2017-01-14T17:49:26Z

GuillaumeGomez · 2017-01-15T00:11:15Z

failures:

---- sys::imp::ext::ffi::OsStrExt::as_bytes_0 stdout ----
	error[E0432]: unresolved import `std::os::ffi::OsStrExt`
 --> <anon>:5:5
  |
5 | use std::os::ffi::OsStrExt;
  |     ^^^^^^^^^^^^^^^^^^^^^^ Could not find `ffi` in `os`

error: no method named `as_bytes` found for type `&std::ffi::OsStr` in the current scope
 --> <anon>:8:20
  |
8 | let bytes = os_str.as_bytes();
  |                    ^^^^^^^^
  |
  = help: items from traits can only be used if the trait is in scope; the following trait is implemented but not in scope, perhaps add a `use` for it:
  = help: candidate #1: `use std::os::ext::ffi::OsStrExt;`

error: aborting due to previous error(s)

thread 'sys::imp::ext::ffi::OsStrExt::as_bytes_0' panicked at 'Box<Any>', /checkout/src/librustc/session/mod.rs:203
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- sys::imp::ext::ffi::OsStrExt::from_bytes_0 stdout ----
	error[E0432]: unresolved import `std::os::ffi::OsStrExt`
 --> <anon>:5:5
  |
5 | use std::os::ffi::OsStrExt;
  |     ^^^^^^^^^^^^^^^^^^^^^^ Could not find `ffi` in `os`

error: no associated item named `from_bytes` found for type `std::ffi::OsStr` in the current scope
 --> <anon>:8:14
  |
8 | let os_str = OsStr::from_bytes(bytes);
  |              ^^^^^^^^^^^^^^^^^
  |
  = help: items from traits can only be used if the trait is in scope; the following trait is implemented but not in scope, perhaps add a `use` for it:
  = help: candidate #1: `use std::os::ext::ffi::OsStrExt;`

error: aborting due to previous error(s)

thread 'sys::imp::ext::ffi::OsStrExt::from_bytes_0' panicked at 'Box<Any>', /checkout/src/librustc/session/mod.rs:203

---- sys::imp::ext::ffi::OsStringExt::from_vec_0 stdout ----
	error[E0432]: unresolved import `std::os::ffi::OsStringExt`
 --> <anon>:5:5
  |
5 | use std::os::ffi::OsStringExt;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^ Could not find `ffi` in `os`

error: no associated item named `from_vec` found for type `std::ffi::OsString` in the current scope
 --> <anon>:8:17
  |
8 | let os_string = OsString::from_vec(bytes);
  |                 ^^^^^^^^^^^^^^^^^^
  |
  = help: items from traits can only be used if the trait is in scope; the following trait is implemented but not in scope, perhaps add a `use` for it:
  = help: candidate #1: `use std::os::ext::ffi::OsStringExt;`

error: aborting due to previous error(s)

thread 'sys::imp::ext::ffi::OsStringExt::from_vec_0' panicked at 'Box<Any>', /checkout/src/librustc/session/mod.rs:203

---- sys::imp::ext::ffi::OsStringExt::into_vec_0 stdout ----
	error[E0432]: unresolved import `std::os::ffi::OsStringExt`
 --> <anon>:5:5
  |
5 | use std::os::ffi::OsStringExt;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^ Could not find `ffi` in `os`

error: no method named `into_vec` found for type `std::ffi::OsString` in the current scope
 --> <anon>:9:23
  |
9 | let bytes = os_string.into_vec();
  |                       ^^^^^^^^
  |
  = help: items from traits can only be used if the trait is in scope; the following trait is implemented but not in scope, perhaps add a `use` for it:
  = help: candidate #1: `use std::os::ext::ffi::OsStringExt;`

error: aborting due to previous error(s)

GuillaumeGomez

Just a few little things missing.

GuillaumeGomez · 2017-01-15T00:09:30Z

src/libstd/sys/unix/ext/ffi.rs

@@ -43,9 +66,32 @@ impl OsStringExt for OsString {
 #[stable(feature = "rust1", since = "1.0.0")]
 pub trait OsStrExt {
    #[stable(feature = "rust1", since = "1.0.0")]
+    /// Creates an `OsStr` from a byte slice.


Missing url.

GuillaumeGomez · 2017-01-15T00:09:46Z

src/libstd/sys/unix/ext/ffi.rs

+    /// let bytes = b"foo";
+    /// let os_str = OsStr::from_bytes(bytes);
+    /// assert_eq!(os_str.to_str(), Some("foo"));
+    /// ```
    fn from_bytes(slice: &[u8]) -> &Self;

    /// Gets the underlying byte view of the `OsStr` slice.


Could you add the missing url here as well please?

GuillaumeGomez · 2017-01-15T00:10:04Z

src/libstd/sys/unix/ext/ffi.rs

+    /// let bytes = b"foo".to_vec();
+    /// let os_string = OsString::from_vec(bytes);
+    /// assert_eq!(os_string.to_str(), Some("foo"));
+    /// ```
    #[stable(feature = "rust1", since = "1.0.0")]
    fn from_vec(vec: Vec<u8>) -> Self;

    /// Yields the underlying byte vector of this `OsString`.


Could you add the missing url here as well please?

GuillaumeGomez · 2017-01-15T00:10:07Z

src/libstd/sys/unix/ext/ffi.rs

@@ -21,10 +21,33 @@ use sys_common::{FromInner, IntoInner, AsInner};
 #[stable(feature = "rust1", since = "1.0.0")]
 pub trait OsStringExt {
    /// Creates an `OsString` from a byte vector.


Could you add the missing url here as well please?

frewsxcv · 2017-01-15T15:14:26Z

Comments have been addressed. Tests pass on Travis.

GuillaumeGomez · 2017-01-15T17:39:26Z

Thanks!

@bors: r+ rollup

bors · 2017-01-15T17:39:27Z

📌 Commit de73e52 has been approved by GuillaumeGomez

bors · 2017-01-16T16:01:44Z

⌛ Testing commit de73e52 with merge 1a5c87f...

bors · 2017-01-16T16:06:52Z

💔 Test failed - status-travis

alexcrichton · 2017-01-16T18:10:06Z

@bors: retry * netbsd network failure #39097

…

On Mon, Jan 16, 2017 at 8:06 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/192401713> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#39065 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95OOMjL6JZyBB9dtMZyNp99KVkU2Uks5rS5WegaJpZM4LjsKP> .

…=GuillaumeGomez Add doc examples & description in `std::os::unix::ffi`. None

Rollup of 6 pull requests - Successful merges: #38247, #39028, #39065, #39084, #39105, #39106 - Failed merges:

rust-highfive assigned GuillaumeGomez Jan 14, 2017

GuillaumeGomez requested changes Jan 15, 2017

View reviewed changes

frewsxcv force-pushed the libstd-os-unix-ffi-docs branch from 35b5026 to 617e97c Compare January 15, 2017 02:34

Add doc examples & description in std::os::unix::ffi.

de73e52

frewsxcv force-pushed the libstd-os-unix-ffi-docs branch from 617e97c to de73e52 Compare January 15, 2017 03:35

GuillaumeGomez approved these changes Jan 15, 2017

View reviewed changes

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 16, 2017

Rollup merge of rust-lang#39065 - frewsxcv:libstd-os-unix-ffi-docs, r…

0492139

…=GuillaumeGomez Add doc examples & description in `std::os::unix::ffi`. None

GuillaumeGomez mentioned this pull request Jan 16, 2017

Rollup of 6 pull requests #39108

Merged

bors added a commit that referenced this pull request Jan 16, 2017

Auto merge of #39108 - GuillaumeGomez:rollup, r=GuillaumeGomez

c2b19c1

Rollup of 6 pull requests - Successful merges: #38247, #39028, #39065, #39084, #39105, #39106 - Failed merges:

bors merged commit de73e52 into rust-lang:master Jan 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add doc examples & description in `std::os::unix::ffi`. #39065

Add doc examples & description in `std::os::unix::ffi`. #39065

Uh oh!

frewsxcv commented Jan 14, 2017

Uh oh!

frewsxcv commented Jan 14, 2017

Uh oh!

GuillaumeGomez commented Jan 15, 2017

Uh oh!

GuillaumeGomez left a comment

Uh oh!

GuillaumeGomez Jan 15, 2017

Uh oh!

GuillaumeGomez Jan 15, 2017

Uh oh!

GuillaumeGomez Jan 15, 2017

Uh oh!

GuillaumeGomez Jan 15, 2017

Uh oh!

frewsxcv commented Jan 15, 2017

Uh oh!

GuillaumeGomez commented Jan 15, 2017

Uh oh!

bors commented Jan 15, 2017

Uh oh!

bors commented Jan 16, 2017

Uh oh!

bors commented Jan 16, 2017

Uh oh!

alexcrichton commented Jan 16, 2017 via email

Uh oh!

Uh oh!

Add doc examples & description in std::os::unix::ffi. #39065

Add doc examples & description in std::os::unix::ffi. #39065

Uh oh!

Conversation

frewsxcv commented Jan 14, 2017

Uh oh!

frewsxcv commented Jan 14, 2017

Uh oh!

GuillaumeGomez commented Jan 15, 2017

Uh oh!

GuillaumeGomez left a comment

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Jan 15, 2017

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Jan 15, 2017

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Jan 15, 2017

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Jan 15, 2017

Choose a reason for hiding this comment

Uh oh!

frewsxcv commented Jan 15, 2017

Uh oh!

GuillaumeGomez commented Jan 15, 2017

Uh oh!

bors commented Jan 15, 2017

Uh oh!

bors commented Jan 16, 2017

Uh oh!

bors commented Jan 16, 2017

Uh oh!

alexcrichton commented Jan 16, 2017 via email

Uh oh!

Uh oh!

Add doc examples & description in `std::os::unix::ffi`. #39065

Add doc examples & description in `std::os::unix::ffi`. #39065