Skip to content

Document the optional extra arguments to assert_eq!() / assert_ne!() #38247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2017
Merged

Document the optional extra arguments to assert_eq!() / assert_ne!() #38247

merged 1 commit into from
Jan 17, 2017

Conversation

federicomenaquintero
Copy link
Contributor

And clarify that those arguments in assert!() are in fact formattable.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@federicomenaquintero
Copy link
Contributor Author

Apparently the extra arguments got added in 1.11.0. Do the docs need to mention this? I don't know the convention for documenting new features that only work starting at a certain version.

@steveklabnik
Copy link
Member

steveklabnik commented Dec 9, 2016 via email

@federicomenaquintero
Copy link
Contributor Author

Oh, ok - then I guess the changes are complete :)

@mrhota
Copy link
Contributor

mrhota commented Jan 11, 2017

@federicomenaquintero do you have time to rebase? if not, I can do it, but you'll need to close this PR and I'll issue a new one

@federicomenaquintero
Document the optional extra arguments to assert_eq!() / assert_ne!()
ff5ba73 
And clarify that those arguments in assert!() are in fact formattable.
@federicomenaquintero
Copy link
Contributor Author

I've pushed a rebased version to the same branch.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 15, 2017

📌 Commit ff5ba73 has been approved by GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Jan 16, 2017

⌛ Testing commit ff5ba73 with merge 457b6f3...

@bors
Copy link
Collaborator

bors commented Jan 16, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Jan 16, 2017 via email

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 16, 2017
@GuillaumeGomez
Rollup merge of rust-lang#38247 - federicomenaquintero:assert-eq-argu…
1293b79 
…ment-docs, r=GuillaumeGomez

Document the optional extra arguments to assert_eq!() / assert_ne!()

And clarify that those arguments in assert!() are in fact formattable.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 16, 2017
Merged
bors added a commit that referenced this pull request Jan 16, 2017
@bors
Auto merge of #39108 - GuillaumeGomez:rollup, r=GuillaumeGomez
c2b19c1 
Rollup of 6 pull requests

- Successful merges: #38247, #39028, #39065, #39084, #39105, #39106
- Failed merges:
@bors bors merged commit ff5ba73 into rust-lang:master Jan 17, 2017
@federicomenaquintero federicomenaquintero deleted the assert-eq-argument-docs branch January 26, 2017 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@federicomenaquintero @rust-highfive @steveklabnik @mrhota @GuillaumeGomez @bors @alexcrichton @brson