rustdoc: Use create_dir_all to create directories #33227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a race condition where a directory is created in between the Path::exists check and the fs::create_dir call. This race condition is triggered sometimes by running a command like `cargo doc -p foo -p bar`, which can run multiple rustdoc commands in parallel.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks for the PR! I think this was actually just addressed by #33191, so I'm going to close in favor of that. |
|
Also, just FYI, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race condition where a directory is created in between the Path::exists check and the fs::create_dir call. This race condition is triggered sometimes by running a command like
cargo doc -p foo -p bar, which can run multiple rustdoc commands in parallel.