Skip to content

rustdoc: Handle concurrent mkdir requests #33191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2016

Conversation

alexcrichton
Copy link
Member

It's likely that rustdoc as a tool is run concurrently in the same output
(e.g. documenting multiple crates as Cargo does), in which case it needs to
handle concurrent calls to fs::create_dir.

It's likely that `rustdoc` as a tool is run concurrently in the same output
(e.g. documenting multiple crates as Cargo does), in which case it needs to
handle concurrent calls to `fs::create_dir`.
@rust-highfive
Copy link
Contributor

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez
Copy link
Member

Thanks!

r=me @steveklabnik

@sanxiyn
Copy link
Member

sanxiyn commented Apr 26, 2016

@bors r=GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Apr 26, 2016

📌 Commit 36d9ee3 has been approved by GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Apr 26, 2016

⌛ Testing commit 36d9ee3 with merge 70aafcf...

@bors
Copy link
Collaborator

bors commented Apr 26, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@GuillaumeGomez
Copy link
Member

@bors: retry

@steveklabnik
Copy link
Member

@bors: r-

@GuillaumeGomez let's talk on IRC today, I'll be around in an hour at most.

On Apr 26, 2016, 08:03 -0400, Guillaume [email protected], wrote:

@bors(https://github.com/bors): retry


You are receiving this because you were mentioned.
Reply to this email directly orview it on GitHub(#33191 (comment))

@GuillaumeGomez
Copy link
Member

A double-check by @rust-lang/tools team is required here. :)

@steveklabnik
Copy link
Member

@bors: r+ retry

(While I did ask @GuillaumeGomez to ping @rust-lang/tools generally on rustdoc PRs, this one is straightforward enough that I feel good about merging, and the CI failures were spurious. Re-assigning to me, though, since I was the original reviewer)

@bors
Copy link
Collaborator

bors commented Apr 26, 2016

📌 Commit 36d9ee3 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Apr 26, 2016

⌛ Testing commit 36d9ee3 with merge 897199a...

bors added a commit that referenced this pull request Apr 26, 2016
…eveklabnik

rustdoc: Handle concurrent mkdir requests

It's likely that `rustdoc` as a tool is run concurrently in the same output
(e.g. documenting multiple crates as Cargo does), in which case it needs to
handle concurrent calls to `fs::create_dir`.
@bors bors merged commit 36d9ee3 into rust-lang:master Apr 26, 2016
@alexcrichton alexcrichton deleted the rustdoc-create-dir-all-racy branch April 26, 2016 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants