-
Notifications
You must be signed in to change notification settings - Fork 13.4k
rustdoc: Handle concurrent mkdir requests #33191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Handle concurrent mkdir requests #33191
Conversation
It's likely that `rustdoc` as a tool is run concurrently in the same output (e.g. documenting multiple crates as Cargo does), in which case it needs to handle concurrent calls to `fs::create_dir`.
(rust_highfive has picked a reviewer for you, use r? to override) |
Thanks! r=me @steveklabnik |
@bors r=GuillaumeGomez |
📌 Commit 36d9ee3 has been approved by |
⌛ Testing commit 36d9ee3 with merge 70aafcf... |
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
@bors: retry |
@bors: r- @GuillaumeGomez let's talk on IRC today, I'll be around in an hour at most. On Apr 26, 2016, 08:03 -0400, Guillaume [email protected], wrote:
|
A double-check by @rust-lang/tools team is required here. :) |
@bors: r+ retry (While I did ask @GuillaumeGomez to ping @rust-lang/tools generally on rustdoc PRs, this one is straightforward enough that I feel good about merging, and the CI failures were spurious. Re-assigning to me, though, since I was the original reviewer) |
📌 Commit 36d9ee3 has been approved by |
…eveklabnik rustdoc: Handle concurrent mkdir requests It's likely that `rustdoc` as a tool is run concurrently in the same output (e.g. documenting multiple crates as Cargo does), in which case it needs to handle concurrent calls to `fs::create_dir`.
It's likely that
rustdoc
as a tool is run concurrently in the same output(e.g. documenting multiple crates as Cargo does), in which case it needs to
handle concurrent calls to
fs::create_dir
.