Rollup of 6 pull requests #29899
Closed
Rollup of 6 pull requests #29899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Nov 17, 2015
steveklabnik
commented
- Successful merges: Remove claims of dependency-free libcore #29612, Mention libc from crates.io in TRPL: FFI #29888, Clear up the reference around let #29889, Clarify comment about structs and lifetimes #29890, Fix up escapes in the reference #29891, More docs for FromIterator #29892
- Failed merges:
And modifying IntoIterator for consisntency with it. Part of rust-lang#29360
First, re-word the section on if let/while let to be more clear. Second, actually call them let statements in the statement section Fixes rust-lang#29801
libcore does have a few deps, like noted in rust-lang#29390 Fixes rust-lang#29502
libcore does have a few deps, like noted in rust-lang#29390 Fixes rust-lang#29502 r? @alexcrichton
First, re-word the section on if let/while let to be more clear. Second, actually call them let statements in the statement section Fixes rust-lang#29801
…excrichton And modifying IntoIterator for consisntency with it. Part of rust-lang#29360
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
📌 Commit 04fa860 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.