Skip to content

Clear up the reference around let #29889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2015
Merged

Conversation

steveklabnik
Copy link
Member

First, re-word the section on if let/while let to be more clear.

Second, actually call them let statements in the statement section

Fixes #29801

@rust-highfive
Copy link
Contributor

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

loop body block executes and control returns to the pattern matching statement.
Otherwise, the while expression completes.
A `while let` loop is semantically identical to a `while` loop but in place of
a condition expression it expects `let` statement with a refuatble pattern. If
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

speling

@Manishearth
Copy link
Member

r=me once the spelling is fixed

@steveklabnik
Copy link
Member Author

@bors: r=manishearth rollup

@bors
Copy link
Collaborator

bors commented Nov 17, 2015

📌 Commit 9ecdaa7 has been approved by manishearth

expression on the right hand side of the let statement matches the pattern, the corresponding
block will execute, otherwise flow proceeds to the first `else` block that follows.
An `if let` expression is semantically identical to an `if` expression but in
place of a condition expression it expects a `let` statement with a refuatble
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: refuatable --> refutable

@steveklabnik
Copy link
Member Author

@bors: r=manishearth rollup

@bors
Copy link
Collaborator

bors commented Nov 17, 2015

📌 Commit cf384c2 has been approved by manishearth

First, re-word the section on if let/while let to be more clear.

Second, actually call them let statements in the statement section

Fixes rust-lang#29801
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Nov 17, 2015
First, re-word the section on if let/while let to be more clear.

Second, actually call them let statements in the statement section

Fixes rust-lang#29801
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Nov 17, 2015
First, re-word the section on if let/while let to be more clear.

Second, actually call them let statements in the statement section

Fixes rust-lang#29801
bors added a commit that referenced this pull request Nov 17, 2015
@bors bors merged commit cf384c2 into rust-lang:master Nov 18, 2015
@steveklabnik steveklabnik deleted the gh29801 branch June 19, 2016 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants