Rollup of 6 pull requests #28634
Merged
Rollup of 6 pull requests #28634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Sep 24, 2015
steveklabnik
commented
- Successful merges: reference: follow idiom in code snippet #28616, reference: 3 of the 4 things mentioned here are optional #28617, doc: "familiarity" does not need to be repeated here #28618, reference: fix anchor link #28619, reference: not sure this is the right place to discuss design #28620, reference: rename "structure" to the more familiar "struct" #28622
- Failed merges: reference: Unsafe section does not fit under Functions #28621
extend the search path of libraries to /usr/local/lib in `run-make` testsuite. It should permit to find libstdc++.so on usual directory.
walk_expr includes call to visit_expr for subexpressions.
separate use code between openbsd/netbsd. netbsd use c_int and c_uint, but openbsd not, resulting a unused_import error.
We don't actually probe for javac in all circumstances, so if you have javac installed, but don't have antlr4 installed, and you're on Mac OS X, then you'll get a message that javac is missing, even though that's wrong. To fix this, let's just be a bit more generic in the message, so that it's the same no matter what part of the lexer tests you're missing. cc https://www.reddit.com/r/rust/comments/3m199d/running_make_check_on_the_source_code_says_javac/
…crichton We don't actually probe for javac in all circumstances, so if you have javac installed, but don't have antlr4 installed, and you're on Mac OS X, then you'll get a message that javac is missing, even though that's wrong. To fix this, let's just be a bit more generic in the message, so that it's the same no matter what part of the lexer tests you're missing. cc https://www.reddit.com/r/rust/comments/3m199d/running_make_check_on_the_source_code_says_javac/
extend the search path of libraries to /usr/local/lib in `run-make` testsuite. It should permit to find libstdc++.so on usual directory. r? @alexcrichton
separate use code between openbsd/netbsd netbsd use c_int and c_uint, but openbsd not, resulting a unused_import error. r? @alexcrichton problem introduced by rust-lang#28543
…richton Reported by Moonlightning on #rust > 17:13 EDT < Moonlightning> I think I found a bug in the str::matches() documentation. Was it copied from str::split()? :p > 17:13 EDT < Moonlightning> Because it says “The pattern can be a simple `&str`, `char`, or a closure that determines the split.” I changed "determines the split" to "determines if a character matches". It's not super clear, "determines the split" is not super clear to begin with, maybe this can be made better? On the other hand following the link to Pattern provides enough details.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit c3ca182 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.