Skip to content

Added test for 30904 #142183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

Added test for 30904 #142183

merged 1 commit into from
Jun 9, 2025

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented Jun 7, 2025

Test that was deleted by mistake in this commit
564c78a#diff-85d65712084246fc61f287664eef63b0b25ba0a5c8b69a4a59a9454b6a3ebac4

The original issue is still open and the problem is not solved (if this is even a problem, but the error is still here at least)

@rustbot
Copy link
Collaborator

rustbot commented Jun 7, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 7, 2025
@compiler-errors
Copy link
Member

Yeah, it seems like they were distinct issues but one was renamed as a duplicate of the other... 🤔 so sure why not have one more test.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 8, 2025

📌 Commit 143354c has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2025
@Kivooeo
Copy link
Contributor Author

Kivooeo commented Jun 8, 2025

I will remove 3 more tests from top level of ui dir in next pr so it's fine 😄

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 8, 2025
Added test for 30904

Test that was deleted by mistake in this commit
rust-lang@564c78a#diff-85d65712084246fc61f287664eef63b0b25ba0a5c8b69a4a59a9454b6a3ebac4

The original issue is still open and the problem is not solved (if this is even a problem, but the error is still here at least)
bors added a commit that referenced this pull request Jun 9, 2025
Rollup of 12 pull requests

Successful merges:

 - #141803 (Remove rustc's notion of "preferred" alignment AKA `__alignof`)
 - #142053 (Add new Tier-3 targets: `loongarch32-unknown-none*`)
 - #142089 (Replace all uses of sysroot_candidates with get_or_default_sysroot)
 - #142108 (compiler: Add track_caller to AbiMapping::unwrap)
 - #142132 (`tests/ui`: A New Order [6/N])
 - #142162 (UnsafePinned: update get() docs and signature to allow shared mutation)
 - #142171 (`tests/ui`: A New Order [7/N])
 - #142179 (store `target.min_global_align` as an `Align`)
 - #142183 (Added test for 30904)
 - #142194 (Remove all unused feature gates from the compiler)
 - #142199 (Do not free disk space in the `mingw-check-tidy` job)
 - #142210 (Run `mingw-check-tidy` on auto builds)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 29ef4c8 into rust-lang:master Jun 9, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 9, 2025
rust-timer added a commit that referenced this pull request Jun 9, 2025
Rollup merge of #142183 - Kivooeo:30904-test, r=compiler-errors

Added test for 30904

Test that was deleted by mistake in this commit
564c78a#diff-85d65712084246fc61f287664eef63b0b25ba0a5c8b69a4a59a9454b6a3ebac4

The original issue is still open and the problem is not solved (if this is even a problem, but the error is still here at least)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants