`tests/ui`: A New Order [6/N] #142132

Kivooeo · 2025-06-06T20:25:25Z

Note

Intermediate commits are intended to help review, but will be squashed prior to merge.

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

r? @jieyouxu

auxiliary tag means some changes in realted auxiliary file for test

rustbot · 2025-06-06T20:25:29Z

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

Kivooeo · 2025-06-06T21:38:06Z

btw, i don't like this complex.rs test, it feels like it tests nothing, so if you feels the same way we can remove it i guess

tests/ui/runtime/control-flow-runtime-behavior.rs

workingjubilee · 2025-06-07T17:27:50Z

tests/ui/cross-crate/auxiliary/method_reexport_aux.rs

can you leave a comment that points people back to ../cross-crate-method-reexport.rs?

im not sure how exactly this comment should looks like, because i checked other auxiliary files in this directory on none of this files contains something like this

something like?

Original test is located in `tests/ui/cross-crate/cross-crate-method-reexport.rs`

Yes, "used by" is also fine

workingjubilee · 2025-06-07T17:37:59Z

tests/ui/lifetimes/constructor-lifetime-early-binding-error.rs

+//! treated as early bound, similar to associated items, rather than late bound as in manual
+//! constructors.
+//!
+//! Related to issue #30904.


howso? pretend I am too lazy to go look at that issue (because I am)

i guess your question is "how this test actually validates the early-bound behavior" so answer is the test proves early-bound behavior by confirming that partial specification fails with the right error message, if these were late-bound, the error messages might be different
it may be not the best way surely but what we have is what we have

(if that's not what your question was about, you could clarify what you meant)

Oh I meant "how does it relate to that issue"?

as far as i concerned (cuz issue is still open and problem was not fixed yet): the test is mainly to make sure the lifetime mechanism works right, which we'll need for a fix later on (since person who created this test said in their pr that issue was actually fixed, but in reality it doesnt, so this test more indirect relation with this issue)

Suggested change

//! Related to issue #30904.

//! May become a non-error if we fix https://github.com/rust-lang/rust/issues/30904

the errors will still remain after fix, because arguments number does not match the expected one, like here

S::<'static>(&0, &0); //~^ ERROR struct takes 2 lifetime arguments

so i even think about to remove this entire mention of this issue, because it tests slightly different thing

fun part that we had a test for #30904, but it was removed and i cant find this, maybe it was renamed and fully rewritten but i find it hard to believe, here:
https://github.com/JohnTitor/rust/blob/74d45afbf5473d1b255629e786e074060dcc7ec2/src/test/ui/unboxed-closures/issue-30904.rs
if test was really deleted i guess i can add it, because this still true and what issue was about

let _: for<'a> fn(&'a str) -> Str<'a> = Str; //~^ ERROR: mismatched types

Oh, hm.

Yes I think removing the mention of the issue if it's that unrelated is better.

well, yeah, it was deleted in this commit
564c78a#diff-85d65712084246fc61f287664eef63b0b25ba0a5c8b69a4a59a9454b6a3ebac4

but then issue was reopened and test was not brought back, i guess i can add it in separate pr

Kivooeo · 2025-06-07T18:56:47Z

also if you want and agree with changes, i guess, i can squash it so you could r+

workingjubilee · 2025-06-07T18:58:26Z

Yes, I'll sign off on this one.

Kivooeo · 2025-06-07T18:59:22Z

okie, i will ping you as soon as ci passed then

workingjubilee · 2025-06-07T19:38:36Z

Thanks!

@bors r+ rollup

bors · 2025-06-07T19:38:39Z

📌 Commit 610b7a3 has been approved by workingjubilee

It is now in the queue for this repository.

Kivooeo · 2025-06-07T20:15:25Z

fixed the last error with stderr, not actually sure if it should be readded to bors as new commit

workingjubilee · 2025-06-07T20:52:51Z

oh.

yes.

@bors r-
@bors r+ rollup

bors · 2025-06-07T20:52:55Z

📌 Commit 3380a91 has been approved by workingjubilee

It is now in the queue for this repository.

`tests/ui`: A New Order [6/N] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895. r? `@jieyouxu` auxiliary tag means some changes in realted auxiliary file for test

Rollup of 7 pull requests Successful merges: - #141001 (Make NonZero<char> possible) - #141700 (Atomic intrinsics : use const generic ordering, part 2) - #141993 (Use the in-tree `compiler-builtins` for the sysroot) - #142008 (const-eval error: always say in which item the error occurred) - #142053 (Add new Tier-3 targets: `loongarch32-unknown-none*`) - #142132 (`tests/ui`: A New Order [6/N]) - #142179 (store `target.min_global_align` as an `Align`) r? `@ghost` `@rustbot` modify labels: rollup

`tests/ui`: A New Order [6/N] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895. r? ``@jieyouxu`` auxiliary tag means some changes in realted auxiliary file for test

Rollup of 6 pull requests Successful merges: - #141001 (Make NonZero<char> possible) - #141700 (Atomic intrinsics : use const generic ordering, part 2) - #142008 (const-eval error: always say in which item the error occurred) - #142053 (Add new Tier-3 targets: `loongarch32-unknown-none*`) - #142132 (`tests/ui`: A New Order [6/N]) - #142179 (store `target.min_global_align` as an `Align`) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jieyouxu Jun 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 6, 2025

Kivooeo changed the title ~~Tf6~~ tests/ui: A New Order [6/N] Jun 6, 2025

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the tf6 branch from bba17a0 to 7deb00b Compare June 6, 2025 21:36

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the tf6 branch from 7deb00b to e1f69b4 Compare June 6, 2025 21:51

workingjubilee reviewed Jun 7, 2025

View reviewed changes

Kivooeo force-pushed the tf6 branch from e1f69b4 to 0131e29 Compare June 7, 2025 18:57

Kivooeo force-pushed the tf6 branch from 0131e29 to 5e80681 Compare June 7, 2025 18:58

Kivooeo force-pushed the tf6 branch from 5e80681 to 610b7a3 Compare June 7, 2025 19:20

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2025

This comment has been minimized.

Sign in to view

cleaned up some tests

3380a91

Kivooeo force-pushed the tf6 branch from 610b7a3 to 3380a91 Compare June 7, 2025 20:14

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 7, 2025

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 7, 2025

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 7, 2025

matthiaskrgr mentioned this pull request Jun 8, 2025

Rollup of 7 pull requests #142186

Closed

matthiaskrgr mentioned this pull request Jun 8, 2025

Rollup of 6 pull requests #142188

Open

	//! Related to issue #30904.
	//! May become a non-error if we fix https://github.com/rust-lang/rust/issues/30904

tests/ui: A New Order [6/N] #142132

Are you sure you want to change the base?

tests/ui: A New Order [6/N] #142132

Conversation

Kivooeo commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 6, 2025

Uh oh!

This comment has been minimized.

Kivooeo commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo commented Jun 7, 2025

Uh oh!

workingjubilee commented Jun 7, 2025

Uh oh!

Kivooeo commented Jun 7, 2025

Uh oh!

workingjubilee commented Jun 7, 2025

Uh oh!

bors commented Jun 7, 2025

Uh oh!

This comment has been minimized.

Kivooeo commented Jun 7, 2025

Uh oh!

workingjubilee commented Jun 7, 2025

Uh oh!

bors commented Jun 7, 2025

Uh oh!

Uh oh!

`tests/ui`: A New Order [6/N] #142132

`tests/ui`: A New Order [6/N] #142132

Kivooeo commented Jun 6, 2025 •

edited

Loading

Kivooeo commented Jun 6, 2025 •

edited

Loading

Kivooeo Jun 7, 2025 •

edited

Loading

Kivooeo Jun 7, 2025 •

edited

Loading