Rollup of 7 pull requests #142028

matthiaskrgr · 2025-06-04T14:24:13Z

Successful merges:

Streamline some attr parsing APIs #141271 (Streamline some attr parsing APIs)
Fix incorrect eq_unspanned in TokenStream #141570 (Fix incorrect eq_unspanned in TokenStream)
remove f16: From<u16> #141893 (remove f16: From<u16>)
Lightly tweak docs for BTree{Map,Set}::extract_if #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if)
exact_div: add tests #141939 (exact_div: add tests)
Add more missing 2015 edition directives #141959 (Add more missing 2015 edition directives)
Improve some Visitor comments. #142007 (Improve some Visitor comments.)

r? @ghost
@rustbot modify labels: rollup

They are unused.

They're equivalent, and `path` is unused, and `deconstruct` has only one call site outside of `path`.

And avoid the clone.

- Move explanations into comments to match style - Explain the second examples - Make variable names match the data structure

These tests specifically test 2015 edition behavior, so ensure that they can only be run with this edition

For AST/HIR/THIR visitors, explain the use of deconstruction.

…nszelmann Streamline some attr parsing APIs r? ``@jdonszelmann``

…, r=workingjubilee Fix incorrect eq_unspanned in TokenStream Fixes rust-lang#141522 r? ``@workingjubilee`` should we remove this function? since it's used in several places, i'd prefer to keep it.

remove `f16: From<u16>` it's not a lossless conversion r? ``@tgross35``

Lightly tweak docs for BTree{Map,Set}::extract_if - Move explanations into comments to match style - Explain the second examples - Make variable names match the data structure Related rust-lang#70530

…=workingjubilee exact_div: add tests tracking issue: rust-lang#139911 I neglected to add tests in my last PR (rust-lang#141237), so I've added them here. r? ``@workingjubilee`` (Feel free to reroll, I just picked you since you reviewed the last one.)

…es2, r=compiler-errors Add more missing 2015 edition directives These tests specifically test 2015 edition behavior, so ensure that they can only be run with this edition

…enyukang Improve some `Visitor` comments. For AST/HIR/THIR visitors, explain the use of deconstruction. r? ``@BoxyUwU``

matthiaskrgr · 2025-06-04T14:24:25Z

@bors r+ rollup=never p=5

bors · 2025-06-04T14:24:27Z

📌 Commit a06160d has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-06-04T17:40:49Z

⌛ Testing commit a06160d with merge 4b27a04...

bors · 2025-06-04T21:04:45Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 4b27a04 to master...

rust-timer · 2025-06-04T21:06:48Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#141271	Streamline some attr parsing APIs	`f2001ec201192a1482c96bb406803098e36e1912` (link)
#141570	Fix incorrect eq_unspanned in TokenStream	`d4f10cfca371b84a21c73f5a338526d6ccc617b4` (link)
#141893	remove `f16: From<u16>`	`672d8d37d01488921af84ceccd469e15d81a142b` (link)
#141924	Lightly tweak docs for BTree{Map,Set}::extract_if	`ae20815f9eb3e908fd791744247bec790dd0bfc4` (link)
#141939	exact_div: add tests	`76ea3802f6df47c0da34fad2db525b6cb6298851` (link)
#141959	Add more missing 2015 edition directives	`4e9518191bed780d05a840118ba0a8bb70bb842e` (link)
#142007	Improve some `Visitor` comments.	`23a153f500b6ad19b68354d2f90dbdf0a92544b0` (link)

previous master: df8102fe5f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-06-04T21:07:46Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing df8102f (parent) -> 4b27a04 (this PR)

Test differences

Show 22 test diffs

Stage 1

num::i128::test_exact_div: [missing] -> pass (J0)
num::i16::test_exact_div: [missing] -> pass (J0)
num::i32::test_exact_div: [missing] -> pass (J0)
num::i64::test_exact_div: [missing] -> pass (J0)
num::i8::test_exact_div: [missing] -> pass (J0)
num::u128::test_exact_div: [missing] -> pass (J0)
num::u16::test_exact_div: [missing] -> pass (J0)
num::u32::test_exact_div: [missing] -> pass (J0)
num::u64::test_exact_div: [missing] -> pass (J0)
num::u8::test_exact_div: [missing] -> pass (J0)

Additionally, 12 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, mingw-check-2, test-various, x86_64-apple-1, x86_64-gnu, x86_64-gnu-aux, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-2, x86_64-gnu-llvm-20-3, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4b27a04cc8ed4da10a546a871e23e665d03f7a79 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 5553.3s -> 8219.2s (48.0%)
dist-apple-various: 7577.8s -> 6212.5s (-18.0%)
x86_64-apple-2: 5063.8s -> 5725.7s (13.1%)
x86_64-rust-for-linux: 2079.5s -> 2301.0s (10.7%)
aarch64-apple: 5843.5s -> 5293.1s (-9.4%)
dist-powerpc64le-linux-gnu: 5061.2s -> 5432.1s (7.3%)
mingw-check-2: 1955.0s -> 1854.9s (-5.1%)
aarch64-gnu-debug: 3560.6s -> 3732.1s (4.8%)
dist-x86_64-apple: 8837.6s -> 8432.7s (-4.6%)
dist-android: 2440.7s -> 2547.6s (4.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-log-analyzer · 2025-06-05T00:00:47Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Version: 4.2.2
Digest: sha256:ccb2698953eaebd21c7bf6268a94f9c26518a7e38e27e0b83c1fe1ad049819b1
Source commit SHA: 11bd71901bbe5b1630ceea73d27597364c9af683
##[endgroup]
Complete job name: DockerHub mirror
##[group]Run actions/checkout@v4
with:
  persist-credentials: false
  repository: rust-lang/rust
  token: ***

rust-timer · 2025-06-05T00:17:50Z

Finished benchmarking commit (4b27a04): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.8%, -1.2%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[3.2%, 3.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 749.348s -> 750.448s (0.15%)
Artifact size: 371.86 MiB -> 371.80 MiB (-0.02%)

nnethercote and others added 20 commits May 20, 2025 11:58

Remove MetaItemListParser::all_{word,path}_list, which are unused.

ee1c2d5

Remove an unnecessary lifetime.

a822e55

Remove MetaItemParser::{word,word_without_args,path_is}.

ea3b3fd

They are unused.

Remove MetaItemParser::{path,deconstruct}.

2cd2d24

They're equivalent, and `path` is unused, and `deconstruct` has only one call site outside of `path`.

Rename MetaItemParser::path_without_args as MetaItemParser::path.

e5c78de

And avoid the clone.

Fix incorrect eq_unspanned in TokenStream

6b5b97a

remove eq_unspanned from TokenStream

d3347bb

remove f16: From<u16>

80e44de

Lightly tweak docs for BTree{Map,Set}::extract_if

a20cf47

- Move explanations into comments to match style - Explain the second examples - Make variable names match the data structure

add tests

e87f138

Add missing 2015 edition directives

4996946

These tests specifically test 2015 edition behavior, so ensure that they can only be run with this edition

add tests for negative numbers

21a739f

Improve some Visitor comments.

ed300d8

For AST/HIR/THIR visitors, explain the use of deconstruction.

Rollup merge of rust-lang#141271 - nnethercote:attr-streamline, r=jdo…

c1e8fe7

…nszelmann Streamline some attr parsing APIs r? ``@jdonszelmann``

Rollup merge of rust-lang#141570 - chenyukang:yukang-fix-eq_unspanned…

0736a03

…, r=workingjubilee Fix incorrect eq_unspanned in TokenStream Fixes rust-lang#141522 r? ``@workingjubilee`` should we remove this function? since it's used in several places, i'd prefer to keep it.

Rollup merge of rust-lang#141893 - usamoi:lossless, r=tgross35

005490c

remove `f16: From<u16>` it's not a lossless conversion r? ``@tgross35``

Rollup merge of rust-lang#141924 - rs-sac:extr-doc, r=jhpratt

98421b7

Lightly tweak docs for BTree{Map,Set}::extract_if - Move explanations into comments to match style - Explain the second examples - Make variable names match the data structure Related rust-lang#70530

Rollup merge of rust-lang#141959 - ferrocene:lw/2015-edition-directiv…

8209715

…es2, r=compiler-errors Add more missing 2015 edition directives These tests specifically test 2015 edition behavior, so ensure that they can only be run with this edition

Rollup merge of rust-lang#142007 - nnethercote:visitor-comments, r=ch…

a06160d

…enyukang Improve some `Visitor` comments. For AST/HIR/THIR visitors, explain the use of deconstruction. r? ``@BoxyUwU``

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 4, 2025

bors merged commit 4b27a04 into rust-lang:master Jun 4, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 4, 2025

bors mentioned this pull request Jun 4, 2025

Unify wording of "failed to resolve" errors with "cannot find" resolution errors #128086

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #142028

Rollup of 7 pull requests #142028

Uh oh!

matthiaskrgr commented Jun 4, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Jun 4, 2025

Uh oh!

bors commented Jun 4, 2025

Uh oh!

bors commented Jun 4, 2025

Uh oh!

bors commented Jun 4, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 4, 2025

Uh oh!

github-actions bot commented Jun 4, 2025

Stage 1

Uh oh!

rust-log-analyzer commented Jun 5, 2025

Uh oh!

rust-timer commented Jun 5, 2025

Uh oh!

Uh oh!

Rollup of 7 pull requests #142028

Rollup of 7 pull requests #142028

Uh oh!

Conversation

matthiaskrgr commented Jun 4, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Jun 4, 2025

Uh oh!

bors commented Jun 4, 2025

Uh oh!

bors commented Jun 4, 2025

Uh oh!

bors commented Jun 4, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 4, 2025

Uh oh!

github-actions bot commented Jun 4, 2025

Test differences

Stage 1

Job duration changes

Uh oh!

rust-log-analyzer commented Jun 5, 2025

Uh oh!

rust-timer commented Jun 5, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

matthiaskrgr commented Jun 4, 2025 •

edited by rustbot

Loading