Streamline some attr parsing APIs #141271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_attr_parsing |
They are unused.
They're equivalent, and `path` is unused, and `deconstruct` has only one call site outside of `path`.
And avoid the clone.
nnethercote
force-pushed
the
attr-streamline
branch
from
e2092d7 to
e5c78de
Compare
|
@jdonszelmann: two week ping! |
|
@nnethercote hiya! Thanks for the ping and sorry for the wait. I've just made my queue of after-rustweek work and you're in it, as well as some of my own attribute work so we should be able to make some progress here. I'll review it today I hope :) |
|
well, I just did it immediately, it's small enough. I see nothing wrong with this, except maybe that I liked @bors r+ rollup |
bors
added
S-waiting-on-bors
|
Thanks for the fast response! :) |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 4, 2025
…nszelmann Streamline some attr parsing APIs r? `@jdonszelmann`
bors
added a commit
that referenced
this pull request
Jun 4, 2025
Rollup of 9 pull requests Successful merges: - #141271 (Streamline some attr parsing APIs) - #141570 (Fix incorrect eq_unspanned in TokenStream) - #141857 (coretests: move float tests from num to floats module and use a more flexible macro to generate them) - #141893 (remove `f16: From<u16>`) - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if) - #141939 (exact_div: add tests) - #141959 (Add more missing 2015 edition directives) - #142002 (redesign stage 0 std follow-ups part2) - #142007 (Improve some `Visitor` comments.) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jun 4, 2025
Rollup of 7 pull requests Successful merges: - #141271 (Streamline some attr parsing APIs) - #141570 (Fix incorrect eq_unspanned in TokenStream) - #141893 (remove `f16: From<u16>`) - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if) - #141939 (exact_div: add tests) - #141959 (Add more missing 2015 edition directives) - #142007 (Improve some `Visitor` comments.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 4, 2025
Rollup merge of #141271 - nnethercote:attr-streamline, r=jdonszelmann Streamline some attr parsing APIs r? ``@jdonszelmann``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @jdonszelmann