Warning added when dependency crate has async drop types, and the feature is disabled #141253

azhogin · 2025-05-19T14:33:51Z

In continue of #141031.

When dependency crate has non-empty adt_async_destructor table in metadata, and async_drop feature is disabled for local crate, warning will be emitted.

Test dependency-dropped has two revisions - with and without feature enabled. With feature enabled, async drop for dropee is executed ("Async drop" printed). Without the feature enabled, sync drop is executed ("Sync drop" printed) and warning is emitted.

Warning example:

warning: found async drop types in dependecy `async_drop_dep`, but async_drop feature is disabled for `dependency_dropped`
  --> $DIR/dependency-dropped.rs:7:1
   |
LL | #![cfg_attr(with_feature, feature(async_drop))]
   | ^
   |
   = help: if async drop type will be dropped in a crate without `feature(async_drop)`, sync Drop will be used

rustbot · 2025-05-19T14:33:56Z

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

azhogin · 2025-05-19T14:34:20Z

r? oli-obk

oli-obk · 2025-05-19T14:46:35Z

oh nice, that's even more precise than just a feature gate check, as you are specifically inspecting the async drop impls in crate metadata

@bors r+ rollup

bors · 2025-05-19T14:46:38Z

📌 Commit 6105928 has been approved by oli-obk

It is now in the queue for this repository.

Rageking8

Multiple typos of the word "dependency".

Rageking8 · 2025-05-19T15:12:34Z

compiler/rustc_metadata/messages.ftl

@@ -1,6 +1,10 @@
 metadata_as_needed_compatibility =
    linking modifier `as-needed` is only compatible with `dylib` and `framework` linking kinds

+metadata_async_drop_types_in_dependency =
+    found async drop types in dependecy `{$extern_crate}`, but async_drop feature is disabled for `{$local_crate}`


Suggested change

found async drop types in dependecy `{$extern_crate}`, but async_drop feature is disabled for `{$local_crate}`

found async drop types in dependency `{$extern_crate}`, but async_drop feature is disabled for `{$local_crate}`

Thanks, fixed.

Rageking8 · 2025-05-19T15:13:57Z

tests/ui/async-await/async-drop/dependency-dropped.rs

 //@ aux-build:async-drop-dep.rs
 //@ edition:2021

-#![feature(async_drop)]
+#![cfg_attr(with_feature, feature(async_drop))]
+//[without_feature]~^ WARN found async drop types in dependecy `async_drop_dep`, but async_drop feature is disabled for `dependency_dropped`


Suggested change

//[without_feature]~^ WARN found async drop types in dependecy `async_drop_dep`, but async_drop feature is disabled for `dependency_dropped`

//[without_feature]~^ WARN found async drop types in dependency `async_drop_dep`, but async_drop feature is disabled for `dependency_dropped`

Rageking8 · 2025-05-19T15:14:24Z

tests/ui/async-await/async-drop/dependency-dropped.without_feature.stderr

@@ -0,0 +1,10 @@
+warning: found async drop types in dependecy `async_drop_dep`, but async_drop feature is disabled for `dependency_dropped`


Suggested change

warning: found async drop types in dependecy `async_drop_dep`, but async_drop feature is disabled for `dependency_dropped`

warning: found async drop types in dependency `async_drop_dep`, but async_drop feature is disabled for `dependency_dropped`

…-inconsistency-warning, r=oli-obk Warning added when dependency crate has async drop types, and the feature is disabled In continue of rust-lang#141031. When dependency crate has non-empty `adt_async_destructor` table in metadata, and `async_drop` feature is disabled for local crate, warning will be emitted. Test `dependency-dropped` has two revisions - with and without feature enabled. With feature enabled, async drop for dropee is executed ("Async drop" printed). Without the feature enabled, sync drop is executed ("Sync drop" printed) and warning is emitted. Warning example: ``` warning: found async drop types in dependecy `async_drop_dep`, but async_drop feature is disabled for `dependency_dropped` --> $DIR/dependency-dropped.rs:7:1 | LL | #![cfg_attr(with_feature, feature(async_drop))] | ^ | = help: if async drop type will be dropped in a crate without `feature(async_drop)`, sync Drop will be used ```

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#131200 (Handle `rustc_query_system` cases of `rustc::potential_query_instability` lint) - rust-lang#141244 (windows: document that we rely on an undocumented property of GetUserProfileDirectoryW) - rust-lang#141247 (skip compiler tools sanity checks on certain commands) - rust-lang#141248 (fix data race in ReentrantLock fallback for targets without 64bit atomics) - rust-lang#141249 (introduce common macro for `MutVisitor` and `Visitor` to dedup code) - rust-lang#141253 (Warning added when dependency crate has async drop types, and the feature is disabled) r? `@ghost` `@rustbot` modify labels: rollup

oli-obk · 2025-05-19T17:41:40Z

@bors r-

oli-obk · 2025-05-19T18:17:40Z

@bors r+

In case the rollup succeeds, there will be conflicts and you'll have to rebase. At that point this PR will only contain the typo fix

bors · 2025-05-19T18:17:43Z

📌 Commit e192953 has been approved by oli-obk

It is now in the queue for this repository.

Rollup merge of rust-lang#141253 - azhogin:azhogin/async-drop-feature-inconsistency-warning, r=oli-obk Warning added when dependency crate has async drop types, and the feature is disabled In continue of rust-lang#141031. When dependency crate has non-empty `adt_async_destructor` table in metadata, and `async_drop` feature is disabled for local crate, warning will be emitted. Test `dependency-dropped` has two revisions - with and without feature enabled. With feature enabled, async drop for dropee is executed ("Async drop" printed). Without the feature enabled, sync drop is executed ("Sync drop" printed) and warning is emitted. Warning example: ``` warning: found async drop types in dependecy `async_drop_dep`, but async_drop feature is disabled for `dependency_dropped` --> $DIR/dependency-dropped.rs:7:1 | LL | #![cfg_attr(with_feature, feature(async_drop))] | ^ | = help: if async drop type will be dropped in a crate without `feature(async_drop)`, sync Drop will be used ```

bors · 2025-05-19T20:33:20Z

☔ The latest upstream changes (presumably #141255) made this pull request unmergeable. Please resolve the merge conflicts.

…s disabled - typo fixed

oli-obk · 2025-05-20T06:13:24Z

@bors r+ rollup

bors · 2025-05-20T06:13:27Z

📌 Commit 4a99cbb has been approved by oli-obk

It is now in the queue for this repository.

klensy · 2025-05-20T09:54:48Z

Bors didn't go crazy if it merges the same pr second time?

oli-obk · 2025-05-20T10:02:29Z

Bors merges commits 😅 github automatically closes PRs whose commits are in the branch they target. So I think everything just works out

…-inconsistency-warning, r=oli-obk Warning added when dependency crate has async drop types, and the feature is disabled In continue of rust-lang#141031. When dependency crate has non-empty `adt_async_destructor` table in metadata, and `async_drop` feature is disabled for local crate, warning will be emitted. Test `dependency-dropped` has two revisions - with and without feature enabled. With feature enabled, async drop for dropee is executed ("Async drop" printed). Without the feature enabled, sync drop is executed ("Sync drop" printed) and warning is emitted. Warning example: ``` warning: found async drop types in dependecy `async_drop_dep`, but async_drop feature is disabled for `dependency_dropped` --> $DIR/dependency-dropped.rs:7:1 | LL | #![cfg_attr(with_feature, feature(async_drop))] | ^ | = help: if async drop type will be dropped in a crate without `feature(async_drop)`, sync Drop will be used ```

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#139419 (Error on recursive opaque ty in HIR typeck) - rust-lang#141236 (Resolved issue with mismatched types triggering ICE in certain scenarios) - rust-lang#141253 (Warning added when dependency crate has async drop types, and the feature is disabled) - rust-lang#141269 (rustc-dev-guide subtree update) - rust-lang#141275 (`gather_locals`: only visit guard pattern guards when checking the guard) - rust-lang#141279 (`lower_to_hir` cleanups) - rust-lang#141285 (Add tick to `RePlaceholder` debug output) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned nnethercote May 19, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 19, 2025

rustbot assigned oli-obk and unassigned nnethercote May 19, 2025

azhogin force-pushed the azhogin/async-drop-feature-inconsistency-warning branch from f2b3e74 to 6105928 Compare May 19, 2025 14:38

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2025

Rageking8 suggested changes May 19, 2025

View reviewed changes

matthiaskrgr mentioned this pull request May 19, 2025

Rollup of 6 pull requests #141255

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 19, 2025

azhogin force-pushed the azhogin/async-drop-feature-inconsistency-warning branch from 6105928 to e192953 Compare May 19, 2025 18:06

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 19, 2025

Warning when dependency crate has async drop types, and the feature i…

4a99cbb

…s disabled - typo fixed

azhogin force-pushed the azhogin/async-drop-feature-inconsistency-warning branch from e192953 to 4a99cbb Compare May 19, 2025 21:37

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 20, 2025

matthiaskrgr mentioned this pull request May 20, 2025

Rollup of 7 pull requests #141292

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warning added when dependency crate has async drop types, and the feature is disabled #141253

Warning added when dependency crate has async drop types, and the feature is disabled #141253

azhogin commented May 19, 2025

rustbot commented May 19, 2025

azhogin commented May 19, 2025

oli-obk commented May 19, 2025

bors commented May 19, 2025

Rageking8 left a comment

Rageking8 May 19, 2025

azhogin May 19, 2025

Rageking8 May 19, 2025

Rageking8 May 19, 2025

oli-obk commented May 19, 2025

oli-obk commented May 19, 2025

bors commented May 19, 2025

bors commented May 19, 2025

oli-obk commented May 20, 2025

bors commented May 20, 2025

klensy commented May 20, 2025

oli-obk commented May 20, 2025

	found async drop types in dependecy `{$extern_crate}`, but async_drop feature is disabled for `{$local_crate}`
	found async drop types in dependency `{$extern_crate}`, but async_drop feature is disabled for `{$local_crate}`

	//[without_feature]~^ WARN found async drop types in dependecy `async_drop_dep`, but async_drop feature is disabled for `dependency_dropped`
	//[without_feature]~^ WARN found async drop types in dependency `async_drop_dep`, but async_drop feature is disabled for `dependency_dropped`

		@@ -0,0 +1,10 @@
		warning: found async drop types in dependecy `async_drop_dep`, but async_drop feature is disabled for `dependency_dropped`

Warning added when dependency crate has async drop types, and the feature is disabled #141253

Are you sure you want to change the base?

Warning added when dependency crate has async drop types, and the feature is disabled #141253

Conversation

azhogin commented May 19, 2025

rustbot commented May 19, 2025

azhogin commented May 19, 2025

oli-obk commented May 19, 2025

bors commented May 19, 2025

Rageking8 left a comment

Choose a reason for hiding this comment

Rageking8 May 19, 2025

Choose a reason for hiding this comment

azhogin May 19, 2025

Choose a reason for hiding this comment

Rageking8 May 19, 2025

Choose a reason for hiding this comment

Rageking8 May 19, 2025

Choose a reason for hiding this comment

oli-obk commented May 19, 2025

oli-obk commented May 19, 2025

bors commented May 19, 2025

bors commented May 19, 2025

oli-obk commented May 20, 2025

bors commented May 20, 2025

klensy commented May 20, 2025

oli-obk commented May 20, 2025