windows: document that we rely on an undocumented property of GetUserProfileDirectoryW #141244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-windows
|
Documenting this now seems good to me even if we decide to not rely on it later @bors r+ rollup |
bors
added
S-waiting-on-bors
This was referenced May 19, 2025
…ProfileDirectoryW
RalfJung
force-pushed
the
GetUserProfileDirectoryW
branch
from
2e25593 to
a14e25c
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#131200 (Handle `rustc_query_system` cases of `rustc::potential_query_instability` lint) - rust-lang#141244 (windows: document that we rely on an undocumented property of GetUserProfileDirectoryW) - rust-lang#141247 (skip compiler tools sanity checks on certain commands) - rust-lang#141248 (fix data race in ReentrantLock fallback for targets without 64bit atomics) - rust-lang#141249 (introduce common macro for `MutVisitor` and `Visitor` to dedup code) - rust-lang#141253 (Warning added when dependency crate has async drop types, and the feature is disabled) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2025
Rollup merge of rust-lang#141244 - RalfJung:GetUserProfileDirectoryW, r=ChrisDenton windows: document that we rely on an undocumented property of GetUserProfileDirectoryW r? `@ChrisDenton` Also see rust-lang/miri#4332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ChrisDenton
Also see rust-lang/miri#4332