Skip to content

Ensure rustpkg test fails if tests failed #10254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2013
Merged

Ensure rustpkg test fails if tests failed #10254

merged 1 commit into from
Nov 4, 2013

Conversation

sfackler
Copy link
Member

@sfackler sfackler commented Nov 3, 2013

It previously set the exit status, but the main wrapper paved over that
with an exit code of 0.

Closes #9761

@sfackler
Copy link
Member Author

sfackler commented Nov 3, 2013

cc @catamorphism

@alexcrichton
Copy link
Member

Would it be possible to use the testsuite/src directory structure to add a test for this as well?

@sfackler
Copy link
Member Author

sfackler commented Nov 4, 2013

I added a test, but it looks like this change broke the test_no_rebuilding test. I'm thinking that it was always broken, but #9761 masked the failure. Should I just ignore it for now?

@sfackler
Copy link
Member Author

sfackler commented Nov 4, 2013

test_no_rebuilding creates a crate, runs rustpkg test, sets the test binary to read only, and then reruns rustpkg test checking if it failed to compile. However, since the binary is read only, it fails to execute which now generates an error and a non-0 status code.

@alexcrichton
Copy link
Member

Could you open an issue for un-ignoring test_no_rebuilding? If that's in here, then r+ by me.

@sfackler sfackler mentioned this pull request Nov 4, 2013
Closed
@sfackler
Ensure rustpkg test fails if tests failed
ff859ed 
It previously set the exit status, but the main wrapper paved over that
with an exit code of 0.

Closes rust-lang#9761
@sfackler
Copy link
Member Author

sfackler commented Nov 4, 2013

@alexcrichton updated

bors added a commit that referenced this pull request Nov 4, 2013
@bors
auto merge of #10254 : sfackler/rust/rustpkg-test-failure, r=alexcric…
94677c1 
…hton

It previously set the exit status, but the main wrapper paved over that
with an exit code of 0.

Closes #9761
@bors bors closed this Nov 4, 2013
@bors bors merged commit ff859ed into rust-lang:master Nov 4, 2013
@sfackler sfackler deleted the rustpkg-test-failure branch December 23, 2013 03:57
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 10, 2023
@bors
Auto merge of rust-lang#10254 - tylerjw:issue_6929, r=Manishearth
d92070a 
needless_range_loop: improve documentation

fixes rust-lang#6929

changelog: [`needless_range_loop`]: improve documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustpkg test always exits with status code 0
3 participants
@sfackler @alexcrichton @bors