Skip to content

rustpkg test always exits with status code 0 #9761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sfackler opened this issue Oct 8, 2013 · 1 comment · Fixed by #10254
Closed

rustpkg test always exits with status code 0 #9761

sfackler opened this issue Oct 8, 2013 · 1 comment · Fixed by #10254

Comments

@sfackler
Copy link
Member

sfackler commented Oct 8, 2013

BuildContext::test calls os::set_exit_status, but then main overrides that with a status of 0.
@ghost ghost assigned catamorphism Oct 15, 2013
@catamorphism
Copy link
Contributor

Good catch, shouldn't be too hard to fix.

@sfackler sfackler mentioned this issue Nov 3, 2013
Merged
bors added a commit that referenced this issue Nov 4, 2013
@bors
auto merge of #10254 : sfackler/rust/rustpkg-test-failure, r=alexcric…
94677c1 
…hton

It previously set the exit status, but the main wrapper paved over that
with an exit code of 0.

Closes #9761
@bors bors closed this as completed in ff859ed Nov 4, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 21, 2022
@bors
Auto merge of rust-lang#9761 - xFrednet:changelog-1-65, r=giraffate,x…
6b4e7dd 
…Frednet

Changelog for Rust 1.65

Roses are red,
violets are blue,
another 6 weeks,
another changelog, yahoo!

This did not rhyme,
luckily, not a crime.
I want to say something smart,
but I am out of time.

---

Note for the reviewer. This PR is written, as if Rust was already released on 2022-11-03. Please review the changes and approve if you agree, but only merge it after the release. :)

---

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure rustpkg test fails if tests failed sfackler/rust
2 participants
@catamorphism @sfackler