Show a consistent navbar across docs.rs and rustdoc pages #1089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nemo157
force-pushed
the
consistent-navbar
branch
from
af187ad to
609de32
Compare
jyn514
added
A-frontend
|
I think I like this better. @jsha , @GuillaumeGomez , @Kixiron , what do you think? |
|
This is great! I like the consistency across all pages. I have a small branch locally to give the About / Releases / Rust menus the same treatment we recently gave the crate / Source / Platform menus: Click to open and click to close rather than hover. I'll rebase on this branch once it lands. |
|
I prefer this new one as well! |
|
@Nemo157 thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the docs.rs internal navbar links to the right-hand side, and keeps the crate-related navbar links when viewing the crate details/builds/source pages (while removing the dropdown that duplicates the crate details).
There is one remaining issue that I don't want to fix here; the "go to latest version" link doesn't appear on the non-rustdoc pages. The metadata used for rendering builds and source files doesn't currently pull enough details from the database for this, I think it might make the most sense to make both of them get the full
CrateDetailsand move theis_latest_versionetc. checking into Tera helpers rather than being extra context variables, but that seems better done as a separate refactoring.related to #1077
Screenshots: