Skip to content

Show "go to latest version" on crate details pages #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nemo157 opened this issue Oct 13, 2020 · 0 comments
Open

Show "go to latest version" on crate details pages #1093

Nemo157 opened this issue Oct 13, 2020 · 0 comments
Labels
A-frontend Area: Web frontend C-enhancement Category: This is a new feature E-easy Effort: Should be easy to implement and would make a good first PR

Comments

@Nemo157
Copy link
Member

Nemo157 commented Oct 13, 2020

From #1089:

There is one remaining issue that I don't want to fix here; the "go to latest version" link doesn't appear on the non-rustdoc pages. The metadata used for rendering builds and source files doesn't currently pull enough details from the database for this, I think it might make the most sense to make both of them get the full CrateDetails and move the is_latest_version etc. checking into Tera helpers rather than being extra context variables, but that seems better done as a separate refactoring.

I think "go to latest version" on the crate details pages should link to the latest version's crate details page, rather than into the documentation (not sure whether linking directly to source/builds is worth it). It should be possible to simplify the "go to latest version" link on the doc pages as well to use the target-redirect rather than pre-calculating the path to go to, which should make it more consistent to implement across the different pages.

@Nemo157 Nemo157 added A-frontend Area: Web frontend C-enhancement Category: This is a new feature labels Oct 13, 2020
@syphar syphar added the E-easy Effort: Should be easy to implement and would make a good first PR label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend C-enhancement Category: This is a new feature E-easy Effort: Should be easy to implement and would make a good first PR
Projects
None yet
Development

No branches or pull requests

2 participants