Fixup some fallout from the revert of #865 #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I deployed rust-lang#865 Then we reverted that change rust-lang#876 So the migrations that were reverted have been run on production :( These new migrations are idempontent so shouldn't affect anyone who *doesn't* have the reverted migrations...
|
sgrif approved via dm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sooo I have already deployed #865 to production, but not the revert. This means the migration got run, which means we need to undo it, so I've added it back here with the up/down swapped. It shouldn't affect anyone who hasn't run the reverted migration.
I also cherry-picked the commit from #865 that removes
badge_type-- that method is indeed still not being used since we switched to serde, so that commit is fine. In fact, not having this is causing small problems because #807 was made between #865 and the revert, and it adds a new badge, so if I merge in #807 that variant isn't inbadge_type.