Skip to content

Rename gitlab to git-lab #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2017
Merged

Rename gitlab to git-lab #865

merged 2 commits into from
Jul 8, 2017

Conversation

ordian
Copy link

@ordian ordian commented Jul 8, 2017

Follow-up on comment.

@sgrif sgrif merged commit f0e1de8 into rust-lang:master Jul 8, 2017
@ordian ordian deleted the rename_gitlab branch July 8, 2017 20:06
@imp
Copy link

imp commented Jul 10, 2017

Documentation at http://doc.crates.io/manifest.html#package-metadata still mentions "gitlab" instead of the "git-lab"

@ordian
Copy link
Author

ordian commented Jul 10, 2017

Documentation is located in cargo repository. I'm not sure this change is already deployed.

@ordian
Copy link
Author

ordian commented Jul 10, 2017

@sgrif I just noticed, that name git-lab is inconsistent with coverage services:
codecov = { repository = "...", branch = "master", service = "gitlab" }
maybe we should revert this change?

@sgrif
Copy link
Contributor

sgrif commented Jul 10, 2017

@ordian My intention was for this change to only affect how we store things internally and how it's sent to the front-end, not affect what's allowed in Cargo.toml. I see now that this isn't doing that. I'm going to go ahead and revert. We could probably fix it, but honestly this probably isn't worth the effort for such a small change.

@ordian ordian mentioned this pull request Jul 10, 2017
carols10cents added a commit to integer32llc/crates.io that referenced this pull request Jul 11, 2017
I deployed rust-lang#865
Then we reverted that change
rust-lang#876

So the migrations that were reverted have been run on production :(
These new migrations are idempontent so shouldn't affect anyone who
*doesn't* have the reverted migrations...
carols10cents added a commit that referenced this pull request Jul 11, 2017
Fixup some fallout from the revert of #865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants