Skip to content

categories: "mac OS" -> "macOS" #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

categories: "mac OS" -> "macOS" #2663

merged 1 commit into from
Jul 30, 2020

Conversation

woodruffw
Copy link
Contributor

This is a tiny nitpick that I noticed while opening #2662: Apple stylizes their operating system without the space, so I figured consistency with their style makes sense.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jtgeibel (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

JohnTitor
JohnTitor approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's reasonable and I don't think this needs discussion on the meeting, let's go ahead.

@JohnTitor
Copy link
Member

r? @JohnTitor @bors r+

@rust-highfive rust-highfive assigned JohnTitor and unassigned jtgeibel Jul 30, 2020
@bors
Copy link
Contributor

bors commented Jul 30, 2020

📌 Commit abeedb9 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Jul 30, 2020

⌛ Testing commit abeedb9 with merge 2df6cb1...

bors added a commit that referenced this pull request Jul 30, 2020
@bors
Auto merge of #2663 - woodruffw-forks:os-macos-style, r=JohnTitor
2df6cb1 
categories: "mac OS" -> "macOS"

This is a tiny nitpick that I noticed while opening #2662: Apple stylizes their operating system without the space, so I figured consistency with their style makes sense.
@bors
Copy link
Contributor

bors commented Jul 30, 2020

💥 Test timed out

@JohnTitor
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Jul 30, 2020

⌛ Testing commit abeedb9 with merge f4cb469...

@bors
Copy link
Contributor

bors commented Jul 30, 2020

☀️ Test successful - checks-travis
Approved by: JohnTitor
Pushing f4cb469 to master...

@bors bors merged commit f4cb469 into rust-lang:master Jul 30, 2020
@woodruffw woodruffw deleted the os-macos-style branch July 30, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@woodruffw @rust-highfive @JohnTitor @bors @jtgeibel