Skip to content

categories: Add os::linux-apis #2662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2020
Merged

categories: Add os::linux-apis #2662

merged 1 commit into from
Aug 7, 2020

Conversation

woodruffw
Copy link
Contributor

First of all, thank you to the crates.io team! The service and work you provide is invaluable.

I'm opening this PR to propose a new category slug: os::linux-apis. My rationale:

Linux has a large API surface that isn't shared with other
members of the Unix/Unix-like family, so having a separate
category for it allows crate authors to better distinguish
when writing bindings for Linux-specific interfaces.

This is consistent with the availability of os::macos-apis,
as macOS is another member of the Unix/Unix-like family with
its own large and discrete API surface.

@woodruffw
categories: Add os::linux-apis
b8bf226 
Linux has a large API surface that isn't shared with other
members of the Unix/Unix-like family, so having a separate
category for it allows crate authors to better distinguish
when writing bindings for Linux-specific interfaces.

This is consistent with the availability of `os::macos-apis`,
as macOS is another member of the Unix/Unix-like family with
its own large and discrete API surface.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@woodruffw woodruffw mentioned this pull request Jul 28, 2020
Merged
bors added a commit that referenced this pull request Jul 30, 2020
@bors
Auto merge of #2663 - woodruffw-forks:os-macos-style, r=JohnTitor
2df6cb1 
categories: "mac OS" -> "macOS"

This is a tiny nitpick that I noticed while opening #2662: Apple stylizes their operating system without the space, so I figured consistency with their style makes sense.
bors added a commit that referenced this pull request Jul 30, 2020
@bors
Auto merge of #2663 - woodruffw-forks:os-macos-style, r=JohnTitor
f4cb469 
categories: "mac OS" -> "macOS"

This is a tiny nitpick that I noticed while opening #2662: Apple stylizes their operating system without the space, so I figured consistency with their style makes sense.
@jtgeibel jtgeibel mentioned this pull request Jul 31, 2020
Closed
@JohnTitor
Copy link
Member

The team discussed this in today's meeting.
We basically want to accept this, but we'd like to know how many of the crates we currently have fall into this category.
@woodruffw Could you show some crates as examples like #2090 (comment)?

r? @JohnTitor

@rust-highfive rust-highfive assigned JohnTitor and unassigned sgrif Jul 31, 2020
@woodruffw
Copy link
Contributor Author

We basically want to accept this, but we'd like to know how many of the crates we currently have fall into this category.
@woodruffw Could you show some crates as examples like #2090 (comment)?

Sure, I'm happy to! Here are some examples:

@JohnTitor
Copy link
Member

@woodruffw Thanks! But could you show more examples? I think it'd be ideal that there were 10 or so examples. Because we're reluctant to add new (sub)categories and need the reason that "we definitely should add this category!".

@woodruffw
Copy link
Contributor Author

woodruffw commented Aug 5, 2020 via email

@woodruffw
Copy link
Contributor Author

Here are some more examples of crates for Linux-specific APIs and subsystems:

@JohnTitor
Copy link
Member

Thanks a lot! I'll put this on the agenda again at this week's meeting.

@woodruffw
Copy link
Contributor Author

Thanks to you too! I appreciate the background on the review and approval process 😄

JohnTitor
JohnTitor approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this at today's meeting and we're happy to accept it. Thanks again for working on it! This category will be available since next deploying.

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 7, 2020

📌 Commit b8bf226 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Aug 7, 2020

⌛ Testing commit b8bf226 with merge 0099c08...

@bors
Copy link
Contributor

bors commented Aug 7, 2020

☀️ Test successful - checks-travis
Approved by: JohnTitor
Pushing 0099c08 to master...

@bors bors merged commit 0099c08 into rust-lang:master Aug 7, 2020
@woodruffw woodruffw deleted the os-linux-apis-category branch August 7, 2020 16:21
@woodruffw
Copy link
Contributor Author

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@woodruffw @rust-highfive @JohnTitor @bors @sgrif