components: don't infer MSRV based on edition #10108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rust-lang#9996, we started showing the MSRV based on the edition for crate versions that declare an edition but not a `rust-version` in their manifest. This isn't strictly correct: a crate may require features added later in an edition than in the first Rust version that defined that edition, and showing this as an MSRV implies a level of support that the crate author may not have intended. So, we shouldn't show an MSRV if one isn't declared, but we _can_ show the edition if one of those is defined. Let's do that. Fixes rust-lang#10103.
|
Thanks. Showing the edition instead is a good idea and would also solve my issue. |
Turbo87
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume we'll want to bikeshed the tooltip wording here. I don't know if showing the minimum edition version is actually useful, honestly, but I included it for now for discussion purposes.
Visually, this feels like it works out OK:
I toyed with using small caps for the "edition" label on the versions list, but it looked weird with the uppercase "features", so I dropped it.
In #9996, we started showing the MSRV based on the edition for crate versions that declare an edition but not a
rust-versionin their manifest. This isn't strictly correct: a crate may require features added later in an edition than in the first Rust version that defined that edition, and showing this as an MSRV implies a level of support that the crate author may not have intended.So, we shouldn't show an MSRV if one isn't declared, but we can show the edition if one of those is defined. Let's do that.
Fixes #10103.