You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
... added by 93f8da5 causes crates.io to show an MSRV of 1.56.0 on all crates that have Edition 2021 and no explicit MSRV. This led to a user filing a bug on one of my crates that it doesn't compile with the old Rust version they wanted to use. I do not support such an old version of Rust for this crate, and it is misleading of crates.io to show 1.56.0 as the "Minimum Supported Rust Version". Only the crate author gets to decide what versions of Rust are and are not supported, and an arbitrary lower bound inferred from the edition does not mean that version is supported.
Expected Behavior
crates.io should only display the value explicitly specified via the rust-version manifest field, and if it isn't present it should display as "Unknown" or something, not a made-up value.
In rust-lang#9996, we started showing the MSRV based on the edition for crate
versions that declare an edition but not a `rust-version` in their
manifest. This isn't strictly correct: a crate may require features
added later in an edition than in the first Rust version that defined
that edition, and showing this as an MSRV implies a level of support
that the crate author may not have intended.
So, we shouldn't show an MSRV if one isn't declared, but we _can_ show
the edition if one of those is defined. Let's do that.
Fixesrust-lang#10103.
Current Behavior
crates.io/app/models/version.js
Lines 53 to 65 in a27a914
... added by 93f8da5 causes crates.io to show an MSRV of 1.56.0 on all crates that have Edition 2021 and no explicit MSRV. This led to a user filing a bug on one of my crates that it doesn't compile with the old Rust version they wanted to use. I do not support such an old version of Rust for this crate, and it is misleading of crates.io to show 1.56.0 as the "Minimum Supported Rust Version". Only the crate author gets to decide what versions of Rust are and are not supported, and an arbitrary lower bound inferred from the edition does not mean that version is supported.
Expected Behavior
crates.io should only display the value explicitly specified via the
rust-version
manifest field, and if it isn't present it should display as "Unknown" or something, not a made-up value.Steps To Reproduce
https://crates.io/crates/k8s-openapi/versions
Environment
N/A
Anything else?
No response
The text was updated successfully, but these errors were encountered: