-
Notifications
You must be signed in to change notification settings - Fork 6.3k
[Data] Support pandas 2.2.0 for pandas tensor extensions #42892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Scott Lee <[email protected]>
Signed-off-by: Scott Lee <[email protected]>
Signed-off-by: Scott Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bveeramani can you help do a double check?
btw @scottjlee is it possible we add a unit test?
yeah i was attempting this, but wasn't sure how to test different versions of pandas other than adding an entirely new test suite (like we do for various arrow versions). Do you suggest this approach? I did test the PR locally with pandas 1.5 and pandas 2.2.0, and the fix worked for both cases. Moreover, we may want to generalize this pattern to also test floor/ceiling versions of pandas and other critical dependencies. |
SG, we can put the CI test as a followup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Does anyone know which release has included this merged PR? 2.9.3 didn't have it I think. 2.10 is out now. Does that one include this fix? I couldn't tell by looking at the release notes. |
@fehtemam Yes, this fix is included in 2.10. |
Why are these changes needed?
ExtensionArrayFormatter
is replaced with_ ExtensionArrayFormatter
in pandas 2.2.0. If Ray Data users have this version of pandas installed, it will result in the error in #42842.This PR adds the case to support the change to
ExtensionArrayFormatter
. Tested locally with pandas 2.2.0 and Ray Data usage works without the error.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.