Powman fix #2499
Powman fix #2499
Conversation
You can also use gpios 13 and 15 on RP2350
|
LGTM 👍 |
| @@ -102,7 +102,15 @@ static void powman_timer_use_gpio(uint32_t gpio, uint32_t use, uint32_t using) { | |||
| if (was_running) powman_timer_stop(); | |||
| invalid_params_if(HARDWARE_POWMAN, !((gpio == 12) || (gpio == 14) || (gpio == 20) || (gpio == 22))); | |||
There was a problem hiding this comment.
I think i'd like to introduce a POWMAN_GPIO_SOURCE(gpio) macro guarded by an #Ifdef in the header, which contains the invalid_params_if and the source switch. This is just a bit more future proof
There was a problem hiding this comment.
Reminds me a bit of https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/hardware_adc/include/hardware/adc.h#L96 and the ADC_PIN_TO_CHANNEL that was suggested in #1513 😉
There was a problem hiding this comment.
Why a macro and not an inline function? Why would it need to be guarded by an #Ifdef ?
There was a problem hiding this comment.
@kilograham Sorry, I think you're going to have to do this as I can't guess what you want and am likely to get it wrong.
powman_timer_use_gpio is wrong.
And fix the docs for clock_gpio_init etc - spotted while testing powman_timer_use_gpio