Revert "media: bcm2835-codec: Limit video callbacks" #4773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f814bfc. The commit caused media stalls with kodi and stateful v4l2 video decode. John is now using a different way of limiting latency through stateful v4l2 so this is not required.
|
@jc-kynesim okay with you? |
|
Replaces #4658 |
|
Fine by me. I think there must be something about that control that doesn't really work. The patch never worked as well as I hoped - hence the need to fix it in userspace. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Dec 17, 2021
kernel: drm/vc4: Skip writes to disabled packet RAM See: raspberrypi/linux#4770 kernel: BCM2711 KMS YUV Support See: raspberrypi/linux#4777 kernel: Revert media: bcm2835-codec: Limit video callbacks See: raspberrypi/linux#4773 kernel: staging/bcm2835-isp: Fix cleanup after init fail See: raspberrypi/linux#4774
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Dec 17, 2021
kernel: drm/vc4: Skip writes to disabled packet RAM See: raspberrypi/linux#4770 kernel: BCM2711 KMS YUV Support See: raspberrypi/linux#4777 kernel: Revert media: bcm2835-codec: Limit video callbacks See: raspberrypi/linux#4773 kernel: staging/bcm2835-isp: Fix cleanup after init fail See: raspberrypi/linux#4774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f814bfc.
The commit caused media stalls with kodi and stateful
v4l2 video decode.
John is now using a different way of limiting latency
through stateful v4l2 so this is not required.