Skip to content

HTTP API: make GET /api/aliveness-test a no-op (backport #13052) #13053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 11, 2025

This follows the decision that was made for
'rabbitm-diagnostics node_health_check' which
is a no-op as of 4.0.0 following a few years of
deprecation.

The justification is very similar:

  1. There is no such thing as "One True Health Check". A single health check is too coarse-grained to explain what specifically is not right about cluster state
  2. Indivual fine-grained health checks have been available for a few years now, see https://www.rabbitmq.com/docs/monitoring#health-checks
  3. This particular check tests something that effectively never fails, based on my 14+ years of RabbitMQ contributions and user support of all shapes and forms
  4. This check uses a deprecated feature: a non-exclusive non-durable/transient classic queue,
    which it keeps around by design to avoid adding to churn /api/aliveness-test/vhost uses deprecated feature transient_nonexcl_queues with RabbitMQ 4.0.x #13047
  5. Earlier this endpoint was removed from the HTTP API reference

If something about this health check is worth
preserving, we can always add a new one
under GET /api/health/checks/*

Closes #13047.


This is an automatic backport of pull request #13052 done by [Mergify](https://mergify.com).

This follows the decision that was made for
'rabbitm-diagnostics node_health_check' which
is a no-op as of 4.0.0 following a few years of
deprecation.

The justification is very similar:

1. There is no such thing as "One True Health Check".
   A single health check is too coarse-grained to
   explain what specifically is not right about
   cluster state
2. Indivual fine-grained health checks have been
   available for a few years now, see
   https://www.rabbitmq.com/docs/monitoring#health-checks
3. This particular check tests something that
   effectively never fails, based on my 14+
   years of RabbitMQ contributions and user support
   of all shapes and forms
4. This check uses a deprecated feature: non-exclusive
   non-durable/transient classic queues

If something about this health check is worth
preserving, we can always add a new one
under GET /api/health/checks/*

Closes #13047.

(cherry picked from commit ad906c9)
@michaelklishin michaelklishin added this to the 4.0.6 milestone Jan 11, 2025
@michaelklishin michaelklishin merged commit 47a41e8 into v4.0.x Jan 11, 2025
270 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.0.x/pr-13052 branch January 11, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant