HTTP API: make GET /api/aliveness-test a no-op #13052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the decision that was made for 'rabbitm-diagnostics node_health_check' which is a no-op as of 4.0.0 following a few years of deprecation. The justification is very similar: 1. There is no such thing as "One True Health Check". A single health check is too coarse-grained to explain what specifically is not right about cluster state 2. Indivual fine-grained health checks have been available for a few years now, see https://www.rabbitmq.com/docs/monitoring#health-checks 3. This particular check tests something that effectively never fails, based on my 14+ years of RabbitMQ contributions and user support of all shapes and forms 4. This check uses a deprecated feature: non-exclusive non-durable/transient classic queues If something about this health check is worth preserving, we can always add a new one under GET /api/health/checks/* Closes #13047.
michaelklishin
added a commit
that referenced
this pull request
Jan 11, 2025
HTTP API: make GET /api/aliveness-test a no-op (backport #13052)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the decision that was made for
'rabbitm-diagnostics node_health_check' which
is a no-op as of 4.0.0 following a few years of
deprecation.
The justification is very similar:
which it keeps around by design to avoid adding to churn /api/aliveness-test/vhost uses deprecated feature transient_nonexcl_queues with RabbitMQ 4.0.x #13047
If something about this health check is worth
preserving, we can always add a new one
under
GET /api/health/checks/*Closes #13047.