Skip to content

支持 optimization.compressImage #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 20, 2021
Merged

支持 optimization.compressImage #142

merged 8 commits into from
Aug 20, 2021

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Aug 17, 2021 •
edited
Loading

预期是发布 2.0.0 正式版本前的最后一个改动

nighca
nighca commented Aug 17, 2021
View reviewed changes
package.json
@@ -6,7 +6,7 @@
},
"scripts": {
"dev": "ts-node ./src/bin.ts -r ./samples/typescript-react",
"build": "rm -rf lib && tsc",
"build": "rm -rf lib && tsc && chmod +x lib/bin.js",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

方便本地调试

@nighca nighca linked an issue Aug 17, 2021 that may be closed by this pull request
Missing repository field in package.json #104
Closed
nighca
nighca commented Aug 17, 2021
View reviewed changes
src/test.ts

async function test() {
// TODO
throw new Error('Command test is not supported yet')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个等 2.0.0 发布后再做了

liaoyu
liaoyu approved these changes Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@liaoyu liaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fec-builder 不能用 yarn 来安装依赖有啥历史原因么

@nighca
Copy link
Collaborator Author

nighca commented Aug 17, 2021

fec-builder 不能用 yarn 来安装依赖有啥历史原因么

@liaoyu https://github.com/Front-End-Engineering-Cloud/builder#%E4%BD%BF%E7%94%A8

fec-builder 使用 npm-shrinkwrap.json 锁定依赖版本，yarn 不会识别 npm-shrinkwrap.json

yarn 没有类似 npm shrinkwrap 的机制；yarn 虽然有 lock 不过其行为跟 npm lock 类似，跟 shrinkwrap 不同

@liaoyu
Copy link
Collaborator

liaoyu commented Aug 17, 2021

yarn 没有类似 npm shrinkwrap 的机制；yarn 虽然有 lock 不过其行为跟 npm lock 类似，跟 shrinkwrap 不同

学习了~

@nighca nighca merged commit a00bb97 into qiniu:v2 Aug 20, 2021
nighca added a commit that referenced this pull request Aug 27, 2021
@nighca @liaoyu
builder v2 (#131)
179a1fe 
* sv

* without svg

* use file & svgr for svg

* typo

* samples change

* update config

* dev deps & script

* optimize svg support

* drop support for ENV_VARIABLES_FILE

* sv

* update samples

* debug devServer route fallback & module resolution

* enable ts-loader allowTsInNodeModules

* update details

* update README

* extract css

* optimization.addPolyfill

* use asset module instead of loaders

* optimize deps

* update TODO

* beta.1

* throw error in logLifecycle

* beta.2

* upload

* beta.3

* beta.4

* disable svgo for svg transform

* beta.5

* 支持 extractCommon & extractVendor (#2)

* extractCommon & extractVendor

* default vendors

* fix extractVendor

* remove build-config.md

* fix review

* fix extractVendor

* tsconfig 配置调整 (#4)

* open esModuleInterop

* target to es6

* 调整默认的目标浏览器 (#3)

* adjust default target browsers

* use svgr for qiniu portal

* npm audit

* filter ts-loader transpileOnly warning

* beta.7

* 新增 analyze 命令以分析 bundle 依赖 (#132)

* add analyz

* add analyze command

* fix self review

* fix review

* 修复 CI (#134)

* debug build-sample.sh

* debug samples for CI

* update browserslist db

* update circle ci node versions

* serve 时监测配置文件变更 (#133)

* watch build config file change

* typo

* watch for tsconfig.json

* remove useless code

* comment

* typo

* 修复样式修改 hot reload 不生效的问题 (#135)

* fix css hot reload

* optimize env logic

* beta.8

* Upgrade typescript 4.1.x (#137)

* use typescript 4.1.x

* beta.9

* log pretty (#138)

* beta.10

* source map 行为优化 (#139)

* process source map

* beta.11

* upgrade ts-loader

* typo

* use cheap-module-source-map instead of eval-source-map

* move webpack-related fns to utils/webpack

* build-config 支持 npm package 作为 `extends` 目标 (#140)

* support npm package as extends target

* update build-config doc

* support file in npm package

* beta.12

* 支持 `optimization.compressImage` (#142)

* remove sourcemap from TODO

* update build script

* specify webpack config target

* update comment for getServeConfig

* add repository info in package.json

* update command prepare & test

* optimization.compressImage

* update samples

* beta.13

* fix dynamic-import (#143)

* beta.14

* fix Typescript moduleResolution (#144)

* beta.15

Co-authored-by: liaoyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liaoyu liaoyu liaoyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing repository field in package.json
2 participants
@nighca @liaoyu