Skip to content

build-config 支持 npm package 作为 extends 目标 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2021
Merged

build-config 支持 npm package 作为 extends 目标 #140

merged 3 commits into from
Aug 12, 2021

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Aug 11, 2021 •
edited
Loading

liaoyu
liaoyu approved these changes Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@liaoyu liaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm，@qiniu/build-config 源码是放在私有仓库的吗

huangbinjie
huangbinjie reviewed Aug 11, 2021
View reviewed changes
build-config.md

为了避免名字的冲突，所有可以被 `extends` 的 npm package 都要求名称成 `build-config-xxx`，或者 `@xxx/build-config`，或者 `@xxx/build-config-yyy`；

你也可以进一步指定 npm package 中的子目录，如，对于 `"extends": "@qiniu/build-config/portal"`，builder 会尝试使用 `@qiniu/build-config` 包中 `portal/` 目录下的 `build-config.json` 文件。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能直接指定到文件吗 @qiniu/build-config/portal/build-config-dev.json

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以支持，我来加一下吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huangbinjie done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huangbinjie 没别的问题的话 approve 下？

@nighca
Copy link
Collaborator Author

nighca commented Aug 11, 2021

@liaoyu 暂时放在 https://gitlab.qiniu.io/qbox/fe-config ，跟相关 browserslist 配置组织在一起

huangbinjie
huangbinjie approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@huangbinjie huangbinjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看不懂，想要的效果有就行

@nighca nighca merged commit 831dbab into qiniu:v2 Aug 12, 2021
@nighca nighca mentioned this pull request Aug 27, 2021
Merged
nighca added a commit that referenced this pull request Aug 27, 2021
@nighca @liaoyu
builder v2 (#131)
179a1fe 
* sv

* without svg

* use file & svgr for svg

* typo

* samples change

* update config

* dev deps & script

* optimize svg support

* drop support for ENV_VARIABLES_FILE

* sv

* update samples

* debug devServer route fallback & module resolution

* enable ts-loader allowTsInNodeModules

* update details

* update README

* extract css

* optimization.addPolyfill

* use asset module instead of loaders

* optimize deps

* update TODO

* beta.1

* throw error in logLifecycle

* beta.2

* upload

* beta.3

* beta.4

* disable svgo for svg transform

* beta.5

* 支持 extractCommon & extractVendor (#2)

* extractCommon & extractVendor

* default vendors

* fix extractVendor

* remove build-config.md

* fix review

* fix extractVendor

* tsconfig 配置调整 (#4)

* open esModuleInterop

* target to es6

* 调整默认的目标浏览器 (#3)

* adjust default target browsers

* use svgr for qiniu portal

* npm audit

* filter ts-loader transpileOnly warning

* beta.7

* 新增 analyze 命令以分析 bundle 依赖 (#132)

* add analyz

* add analyze command

* fix self review

* fix review

* 修复 CI (#134)

* debug build-sample.sh

* debug samples for CI

* update browserslist db

* update circle ci node versions

* serve 时监测配置文件变更 (#133)

* watch build config file change

* typo

* watch for tsconfig.json

* remove useless code

* comment

* typo

* 修复样式修改 hot reload 不生效的问题 (#135)

* fix css hot reload

* optimize env logic

* beta.8

* Upgrade typescript 4.1.x (#137)

* use typescript 4.1.x

* beta.9

* log pretty (#138)

* beta.10

* source map 行为优化 (#139)

* process source map

* beta.11

* upgrade ts-loader

* typo

* use cheap-module-source-map instead of eval-source-map

* move webpack-related fns to utils/webpack

* build-config 支持 npm package 作为 `extends` 目标 (#140)

* support npm package as extends target

* update build-config doc

* support file in npm package

* beta.12

* 支持 `optimization.compressImage` (#142)

* remove sourcemap from TODO

* update build script

* specify webpack config target

* update comment for getServeConfig

* add repository info in package.json

* update command prepare & test

* optimization.compressImage

* update samples

* beta.13

* fix dynamic-import (#143)

* beta.14

* fix Typescript moduleResolution (#144)

* beta.15

Co-authored-by: liaoyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liaoyu liaoyu liaoyu approved these changes

@huangbinjie huangbinjie huangbinjie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nighca @liaoyu @huangbinjie