Fix typo in test_dataclasses.py #95735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dataclass` was called as a function when it was almost certainly intended to be a decorator. (I don't believe this needs an issue or a news entry)
ericvsmith
added
needs backport to 3.10
|
Thanks @da-woods for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 6, 2022
`dataclass` was called as a function when it was almost certainly intended to be a decorator. (cherry picked from commit 59e09ef) Co-authored-by: da-woods <[email protected]>
|
GH-95740 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 6, 2022
`dataclass` was called as a function when it was almost certainly intended to be a decorator. (cherry picked from commit 59e09ef) Co-authored-by: da-woods <[email protected]>
|
GH-95741 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Aug 6, 2022
`dataclass` was called as a function when it was almost certainly intended to be a decorator. (cherry picked from commit 59e09ef) Co-authored-by: da-woods <[email protected]>
ericvsmith
pushed a commit
that referenced
this pull request
Aug 9, 2022
`dataclass` was called as a function when it was almost certainly intended to be a decorator. (cherry picked from commit 59e09ef) Co-authored-by: da-woods <[email protected]> Co-authored-by: da-woods <[email protected]>
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 11, 2022
`dataclass` was called as a function when it was almost certainly intended to be a decorator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataclasswas called as a function when it was almost certainly intended to be a decorator.(I don't believe this needs an issue or a news entry)