Try to use test_dataclass from CPython #4955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It needs a bit of translation to get it Cythonable (since Cython dataclasses are extension types and so must be at the global scope). At the moment bugs are identified but not fixed
|
test_dataclasses.py is copied almost unmodified from CPython (I applied the bug fix proposed in python/cpython#95735, but that's all) so shouldn't need review. tests/run/test_dataclasses.pyx is automatically generated, so again probably doesn't need much review (I hope). |
This was referenced Aug 6, 2022
|
@scoder I'd like to merge this because I think it'll unlock some useful fixes to cython dataclasses. My opinion is that it's fairly low risk because However if you'd like me to hold off and wait for a proper review then let me know and I'll do so. |
da-woods
added a commit
to da-woods/cython
that referenced
this pull request
Aug 20, 2022
Including kw_only on dataclasses.dataclass, kw_only on individual fields, and the dataclasses.KW_ONLY placeholder marker. Part of cython#4303 Draft for the moment since proper testing will be enabled by cython#4955
|
I'm merging this as threatened on the basis that it's worth it to get some cdef dataclass issues fixed up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It needs a bit of translation to get it Cythonable (since
Cython dataclasses are extension types and so must be at the
global scope).
At the moment bugs are identified but not fixed