[2.7] bpo-29656: Handle PR branches in 'make patchcheck' #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional changes needed to backport: - dropped legacy SVN support from patchcheck - use subprocess.PIPE to silence expected error output - don't try to use subprocess.Popen as a context manager - don't try to pass a keyword argument to str.split() (cherry picked from commit 482f7a2)
|
@brettcannon, @benjaminp I already merged the 3.x backports to make |
|
On second thoughts, having a discrepancy in behaviour between 2.7 and the other active branches concerns me more than any potential glitches in the backport, so I've gone ahead and merged this one as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional changes needed to backport:
(cherry picked from commit 482f7a2)