bpo-29656: Handle PR branches in 'make patchcheck' #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mariatta
approved these changes
Mar 11, 2017
ncoghlan
added a commit
to ncoghlan/cpython
that referenced
this pull request
Mar 12, 2017
(cherry picked from commit 482f7a2)
ncoghlan
added a commit
to ncoghlan/cpython
that referenced
this pull request
Mar 12, 2017
(cherry picked from commit 482f7a2)
ncoghlan
added a commit
that referenced
this pull request
Mar 12, 2017
ncoghlan
added a commit
that referenced
this pull request
Mar 12, 2017
ncoghlan
added a commit
to ncoghlan/cpython
that referenced
this pull request
Mar 12, 2017
Additional changes needed to backport: - dropped legacy SVN support from patchcheck - use subprocess.PIPE to silence expected error output - don't try to use subprocess.Popen as a context manager - don't try to pass a keyword argument to str.split() (cherry picked from commit 482f7a2)
|
And the 2.7 backport: #628 The merge conflict itself was due to the legacy subversion support (which I just removed entirely), but there were also runtime errors due to reliance on features that are all in at least 3.3+ but not in 2.7. Working on this also prompted me to file http://bugs.python.org/issue29798, as even the backported change wasn't working in my 2.7 worktree. |
ncoghlan
added a commit
that referenced
this pull request
Mar 12, 2017
Additional changes needed to backport: - dropped legacy SVN support from patchcheck - use subprocess.PIPE to silence expected error output - don't try to use subprocess.Popen as a context manager - don't try to pass a keyword argument to str.split() (cherry picked from commit 482f7a2)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Aug 11, 2021
…rowPickling Upstream fix for bpo-39606 broke the test case.
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.